You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/03/30 06:59:28 UTC

[GitHub] [kafka] dajac commented on pull request #11970: MINOR: Move `KafkaYammerMetrics` to server-common

dajac commented on pull request #11970:
URL: https://github.com/apache/kafka/pull/11970#issuecomment-1082699910


   > In a follow-up patch, we can replace these implicit metrics with explicitly ordered maps and ensure that tests cover them.
   
   This makes me a little nervous. Don't get me wrong, using ordered maps is the right thing to do here. We should have done this since the beginning. However, if we migrate to using ordered maps, we should ensure that existing metrics are not broken as the mbeans names depend on the ordering of the map. I guess that this is what you suggest to add tests for them, right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org