You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by DaanHoogland <gi...@git.apache.org> on 2015/08/02 14:22:10 UTC
[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/649
Cloudstack 8656: do away with silently ignoring exceptions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-8656
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/649.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #649
----
commit 65dc1d5dbae779939eb45e7aad70110acf260d85
Author: Daan Hoogland <da...@onecht.net>
Date: 2015-08-02T10:48:34Z
CLOUDSTACK-8656: handle template properties loading
commit 033ac3b1015aa3a20d6700fce75d49bd2e2bd082
Author: Daan Hoogland <da...@onecht.net>
Date: 2015-08-02T10:52:33Z
CLOUDSTACK-8656: messages on errors closing streams for local templates
commit 89bd6d020fdf359feb1f3c61879011a7dbca9a76
Author: Daan Hoogland <da...@onecht.net>
Date: 2015-08-02T10:55:52Z
CLOUDSTACK-8656: info on error closing peering channels
commit 4e65845789643db29b4a1f1789bbb8e1b8e16859
Author: Daan Hoogland <da...@onecht.net>
Date: 2015-08-02T10:58:56Z
CLOUDSTACK-8656: removed unused input stream
there was code to close a stream that was never created
commit 4e2f4069b49573fb25f9a8269edc7f70e3246a0d
Author: Daan Hoogland <da...@onecht.net>
Date: 2015-08-02T12:20:11Z
CLOUDSTACK-8656: log messages on exception in legacy sql upgrade code
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...
Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/649#issuecomment-127359986
I just had a comment on 87ae150.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: Cloudstack 8656: do away with
silently ig...
Posted by Mike Tutkowski <mi...@solidfire.com>.
Yes
On Monday, August 3, 2015, DaanHoogland <gi...@git.apache.org> wrote:
> Github user DaanHoogland commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/649#issuecomment-127284140
>
> @mike-tutkowski are you alright with this now (merge-level allright;)?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org <javascript:;> or
> file a JIRA ticket
> with INFRA.
> ---
>
--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkowski@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
<http://solidfire.com/solution/overview/?video=play>*™*
[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/649#issuecomment-127284140
@mike-tutkowski are you alright with this now (merge-level allright;)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/649#issuecomment-127357042
@mike-tutkowski sorry didn't notice your reply, I added a view more. Can you have a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/649
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/649#issuecomment-127398255
two lgtm and succesful travis, merge gives no conflicts but will do a local build before push anyway
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...
Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/649#issuecomment-127112655
Aside from a few comments on 04e9083c3199effa295e47bc617b9b406adb6109, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/649#issuecomment-127174572
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---