You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "navendu-pottekkat (via GitHub)" <gi...@apache.org> on 2023/03/02 01:21:31 UTC
[GitHub] [apisix] navendu-pottekkat opened a new issue, #8986: docs: missing how to register protos in standalone mode
navendu-pottekkat opened a new issue, #8986:
URL: https://github.com/apache/apisix/issues/8986
### Current State
The current [standalone mode documentation](https://apisix.apache.org/docs/apisix/next/deployment-modes/#standalone) does not explain how to register protos with APISIX in the yaml file.
### Desired State
This additional section should be added to the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] docs: missing how to register protos in standalone mode [apisix]
Posted by "kayx23 (via GitHub)" <gi...@apache.org>.
kayx23 commented on issue #8986:
URL: https://github.com/apache/apisix/issues/8986#issuecomment-1870832320
The content is now available: https://apisix.apache.org/docs/apisix/next/deployment-modes/#how-to-configure-protos
Added by @shreemaan-abhishek in this PR: https://github.com/apache/apisix/pull/9902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nfrankel commented on issue #8986: docs: missing how to register protos in standalone mode
Posted by "nfrankel (via GitHub)" <gi...@apache.org>.
nfrankel commented on issue #8986:
URL: https://github.com/apache/apisix/issues/8986#issuecomment-1451380872
I ended up not using YAML 😅
The idea is to translate something like [this](https://github.com/ajavageek/grpc-apisix/blob/master/model/src/main/proto/model.proto).
You can get your hands on the project and change the [API call](https://github.com/ajavageek/grpc-apisix/blob/master/commands/1.add-proto.sh) to YAML.
If you don't have time, I can do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] ThalysonR commented on issue #8986: docs: missing how to register protos in standalone mode
Posted by "ThalysonR (via GitHub)" <gi...@apache.org>.
ThalysonR commented on issue #8986:
URL: https://github.com/apache/apisix/issues/8986#issuecomment-1498530954
I was looking around for documentation on this exactly and stumbled upon this issue. Since there's still no documentation on it, I decided to check the code and came up with this:
```
routes:
- id: grpc_demo
uri: /grpctest
plugins:
grpc-transcode:
proto_id: helloworld
service: helloworld.Greeter
method: SayHello
upstream:
scheme: grpc
type: roundrobin
nodes:
"grpc-demo:50051": 1
protos:
- id: helloworld
desc: hello world
content: >
syntax = "proto3";
package helloworld;
service Greeter {
rpc SayHello (HelloRequest) returns (HelloReply) {}
}
message HelloRequest {
string name = 1;
}
message HelloReply {
string message = 1;
}
```
For some reason, using numbers as plugin_id didn't work for me btw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Neilblaze commented on issue #8986: docs: missing how to register protos in standalone mode
Posted by "Neilblaze (via GitHub)" <gi...@apache.org>.
Neilblaze commented on issue #8986:
URL: https://github.com/apache/apisix/issues/8986#issuecomment-1453148077
@nfrankel Ah I see now! On it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Neilblaze commented on issue #8986: docs: missing how to register protos in standalone mode
Posted by "Neilblaze (via GitHub)" <gi...@apache.org>.
Neilblaze commented on issue #8986:
URL: https://github.com/apache/apisix/issues/8986#issuecomment-1451604214
@nfrankel @navendu-pottekkat If there's any written doc or guide for the aforementioned I'd love to work on this. 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Ajay-singh1 commented on issue #8986: docs: missing how to register protos in standalone mode
Posted by "Ajay-singh1 (via GitHub)" <gi...@apache.org>.
Ajay-singh1 commented on issue #8986:
URL: https://github.com/apache/apisix/issues/8986#issuecomment-1452975811
I would love to work for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] navendu-pottekkat commented on issue #8986: docs: missing how to register protos in standalone mode
Posted by "navendu-pottekkat (via GitHub)" <gi...@apache.org>.
navendu-pottekkat commented on issue #8986:
URL: https://github.com/apache/apisix/issues/8986#issuecomment-1453044476
@Neilblaze You can use the proto shared above and translate it to standalone. You might have to do some testing to see if it works. You can also use the protos used in the gRPC examples used in the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Neilblaze commented on issue #8986: docs: missing how to register protos in standalone mode
Posted by "Neilblaze (via GitHub)" <gi...@apache.org>.
Neilblaze commented on issue #8986:
URL: https://github.com/apache/apisix/issues/8986#issuecomment-1453141357
will it be something like this? 😄
```yaml
apisix:
node_listen: "127.0.0.1:9080"
http_admin:
listen: "127.0.01:9180"
ssl:
enable: false
proto:
grpc:
- name: model
paths:
- "/path/to/model.proto"
```
and for [this](https://github.com/ajavageek/grpc-apisix/blob/master/model/src/main/proto/model.proto) (in standalone) the proto would look like:
```proto
syntax = "proto3";
message HelloRequest {
string name = 1;
}
message HelloResponse {
string message = 1;
}
```
cc: @nfrankel, @navendu-pottekkat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nfrankel commented on issue #8986: docs: missing how to register protos in standalone mode
Posted by "nfrankel (via GitHub)" <gi...@apache.org>.
nfrankel commented on issue #8986:
URL: https://github.com/apache/apisix/issues/8986#issuecomment-1453144977
@Neilblaze No, you need to have a dedicated proto section in the configuration, with the proto content included.
As @navendu-pottekkat mentioned, you **need** to test to make sure it works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] docs: missing how to register protos in standalone mode [apisix]
Posted by "kayx23 (via GitHub)" <gi...@apache.org>.
kayx23 closed issue #8986: docs: missing how to register protos in standalone mode
URL: https://github.com/apache/apisix/issues/8986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] navendu-pottekkat commented on issue #8986: docs: missing how to register protos in standalone mode
Posted by "navendu-pottekkat (via GitHub)" <gi...@apache.org>.
navendu-pottekkat commented on issue #8986:
URL: https://github.com/apache/apisix/issues/8986#issuecomment-1451135959
@nfrankel Could you comment the example you used here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org