Re: Question about RemoteIPInternalProxyList (PR 62220)

[Yann Ylavic <yl...@gmail.com>]

Hi Christophe,

responding here rather than in your latest "Bug 62220" thread because
it relates to your below debugging.

On Fri, Apr 6, 2018 at 9:56 PM, Marion et Christophe JAILLET
<ch...@wanadoo.fr> wrote:
>
> Le 06/04/2018 à 20:23, Eric Covener a écrit :
>>
>> is it broken w/o vhosts? I am not sure cmd->server is right for
>> EXEC_ON_READ?  Maybe something in this neighborhood?
>
> at least the 'config' used in 'proxies_set()' is not the same when parsing
> RemoteIPInternalProxyList  and RemoteIPInternalProxy directives.
> And yes, according to my test, it seems to work without vhosts.

I tried to comment/disable remoteip_hook_pre_config() and got the same
server config for both directives.
Does it work better with the attached patch (not sure about the real
test to be done)?

Regards,
Yann.

Re: Question about RemoteIPInternalProxyList (PR 62220)

[Martynas Bendorius <ma...@martynas.it>]

I've tested the patch, it works great!

--
Best regards,
Martynas Bendorius


> On 31 May 2018, at 01:02, Yann Ylavic <yl...@gmail.com> wrote:
> 
> Hi Christophe,
> 
> responding here rather than in your latest "Bug 62220" thread because
> it relates to your below debugging.
> 
> On Fri, Apr 6, 2018 at 9:56 PM, Marion et Christophe JAILLET
> <ch...@wanadoo.fr> wrote:
>> 
>> Le 06/04/2018 à 20:23, Eric Covener a écrit :
>>> 
>>> is it broken w/o vhosts? I am not sure cmd->server is right for
>>> EXEC_ON_READ?  Maybe something in this neighborhood?
>> 
>> at least the 'config' used in 'proxies_set()' is not the same when parsing
>> RemoteIPInternalProxyList  and RemoteIPInternalProxy directives.
>> And yes, according to my test, it seems to work without vhosts.
> 
> I tried to comment/disable remoteip_hook_pre_config() and got the same
> server config for both directives.
> Does it work better with the attached patch (not sure about the real
> test to be done)?
> 
> Regards,
> Yann.
> <remoteip_no_pre_config.diff>