You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-commits@hadoop.apache.org by dh...@apache.org on 2009/11/18 08:57:19 UTC

svn commit: r881695 - in /hadoop/hdfs/trunk: CHANGES.txt src/java/org/apache/hadoop/hdfs/server/datanode/DataBlockScanner.java

Author: dhruba
Date: Wed Nov 18 07:57:19 2009
New Revision: 881695

URL: http://svn.apache.org/viewvc?rev=881695&view=rev
Log:
HDFS-763. Fix slightly misleading report from DataBlockScanner 
about corrupted scans. (dhruba)


Modified:
    hadoop/hdfs/trunk/CHANGES.txt
    hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/datanode/DataBlockScanner.java

Modified: hadoop/hdfs/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hdfs/trunk/CHANGES.txt?rev=881695&r1=881694&r2=881695&view=diff
==============================================================================
--- hadoop/hdfs/trunk/CHANGES.txt (original)
+++ hadoop/hdfs/trunk/CHANGES.txt Wed Nov 18 07:57:19 2009
@@ -62,6 +62,9 @@
     the file (cos, szetszwo)
 
     HDFS-706. Intermittent failures in TestFiHFlush (cos)
+ 
+    HDFS-763. Fix slightly misleading report from DataBlockScanner 
+    about corrupted scans. (dhruba)
 
 Release 0.21.0 - Unreleased
 

Modified: hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/datanode/DataBlockScanner.java
URL: http://svn.apache.org/viewvc/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/datanode/DataBlockScanner.java?rev=881695&r1=881694&r2=881695&view=diff
==============================================================================
--- hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/datanode/DataBlockScanner.java (original)
+++ hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/datanode/DataBlockScanner.java Wed Nov 18 07:57:19 2009
@@ -451,7 +451,6 @@
         return;
       } catch (IOException e) {
 
-        totalScanErrors++;
         updateScanStatus(block, ScanType.VERIFICATION_SCAN, false);
 
         // If the block does not exists anymore, then its not an error
@@ -467,6 +466,7 @@
                  StringUtils.stringifyException(e));
         
         if (second) {
+          totalScanErrors++;
           datanode.getMetrics().blockVerificationFailures.inc(); 
           handleScanFailure(block);
           return;