You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "orpiske (via GitHub)" <gi...@apache.org> on 2023/06/07 15:40:28 UTC
[GitHub] [camel] orpiske opened a new pull request, #10285: (chores) camel-core: test isolation + parallelization fixes
orpiske opened a new pull request, #10285:
URL: https://github.com/apache/camel/pull/10285
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10285: (chores) camel-core: test isolation + parallelization fixes
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10285:
URL: https://github.com/apache/camel/pull/10285#issuecomment-1581086538
These are particularly problematic on s390x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on a diff in pull request #10285: (chores) camel-core: test isolation + parallelization fixes
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on code in PR #10285:
URL: https://github.com/apache/camel/pull/10285#discussion_r1222497450
##########
core/camel-core/src/test/java/org/apache/camel/impl/ScheduledPollConsumerBackoffTest.java:
##########
@@ -22,10 +22,12 @@
import org.apache.camel.spi.PollingConsumerPollStrategy;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.condition.DisabledIfSystemProperty;
+import org.junit.jupiter.api.parallel.Isolated;
import static org.junit.jupiter.api.Assertions.assertEquals;
@DisabledIfSystemProperty(named = "ci.env.name", matches = "github.com", disabledReason = "Flaky on Github CI")
Review Comment:
I don't think so, but it won't hurt to test. Let's give it a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #10285: (chores) camel-core: test isolation + parallelization fixes
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #10285:
URL: https://github.com/apache/camel/pull/10285#issuecomment-1581947693
> 🚫 There are (likely) no components to be tested in this PR
On a side note: we need to implement a tester for the core code: https://issues.apache.org/jira/browse/CAMEL-19427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske merged pull request #10285: (chores) camel-core: test isolation + parallelization fixes
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske merged PR #10285:
URL: https://github.com/apache/camel/pull/10285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10285: (chores) camel-core: test isolation + parallelization fixes
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10285:
URL: https://github.com/apache/camel/pull/10285#issuecomment-1581988778
:no_entry_sign: There are (likely) no components to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on a diff in pull request #10285: (chores) camel-core: test isolation + parallelization fixes
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on code in PR #10285:
URL: https://github.com/apache/camel/pull/10285#discussion_r1221832878
##########
core/camel-core/src/test/java/org/apache/camel/impl/ScheduledPollConsumerBackoffTest.java:
##########
@@ -22,10 +22,12 @@
import org.apache.camel.spi.PollingConsumerPollStrategy;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.condition.DisabledIfSystemProperty;
+import org.junit.jupiter.api.parallel.Isolated;
import static org.junit.jupiter.api.Assertions.assertEquals;
@DisabledIfSystemProperty(named = "ci.env.name", matches = "github.com", disabledReason = "Flaky on Github CI")
Review Comment:
Can it be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10285: (chores) camel-core: test isolation + parallelization fixes
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10285:
URL: https://github.com/apache/camel/pull/10285#issuecomment-1581086049
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
:robot: use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10285: (chores) camel-core: test isolation + parallelization fixes
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10285:
URL: https://github.com/apache/camel/pull/10285#issuecomment-1581163812
:no_entry_sign: There are (likely) no components to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org