[jira] [Commented] (BEAM-646) Get runners out of the apply()

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15702974#comment-15702974 ] 

ASF GitHub Bot commented on BEAM-646:
-------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/1442

    [BEAM-646] Add Replacement Methods to TransformHierarchy, PValue

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    These are used as the underlying mechanism for Pipeline Surgery.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam transform_hierarchy_surgery_methods

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1442.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1442
    
----
commit 09b46520a6a7baa6bd59e69f7ccccbec86a601b5
Author: Thomas Groh <tg...@google.com>
Date:   2016-11-23T02:19:03Z

    Add Replacement Methods to TransformHierarchy, PValue
    
    These are used as the underlying mechanism for Pipeline Surgery.

----


> Get runners out of the apply()
> ------------------------------
>
>                 Key: BEAM-646
>                 URL: https://issues.apache.org/jira/browse/BEAM-646
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Assignee: Thomas Groh
>
> Right now, the runner intercepts calls to apply() and replaces transforms as we go. This means that there is no "original" user graph. For portability and misc architectural benefits, we would like to build the original graph first, and have the runner override later.
> Some runners already work in this manner, but we could integrate it more smoothly, with more validation, via some handy APIs on e.g. the Pipeline object.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)