You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/20 07:58:31 UTC
[GitHub] [incubator-nuttx-apps] YuuichiNakamura opened a new pull request #436: Add note_syscall args support
YuuichiNakamura opened a new pull request #436:
URL: https://github.com/apache/incubator-nuttx-apps/pull/436
## Summary
App code support for https://github.com/apache/incubator-nuttx/pull/2044
## Impact
See https://github.com/apache/incubator-nuttx/pull/2044
## Testing
See https://github.com/apache/incubator-nuttx/pull/2044
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #436: Add note_syscall args support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #436:
URL: https://github.com/apache/incubator-nuttx-apps/pull/436
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #436: Add note_syscall args support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #436:
URL: https://github.com/apache/incubator-nuttx-apps/pull/436#discussion_r508325937
##########
File path: system/trace/trace_dump.c
##########
@@ -451,8 +454,35 @@ static int trace_dump_one(FAR FILE *out,
}
trace_dump_header(out, note, ctx);
- fprintf(out, "sys_%s()\n",
+ fprintf(out, "sys_%s(",
g_funcnames[nsc->nsc_nr - CONFIG_SYS_RESERVED]);
+
+ j = 0;
+ for (i = 0; i < nsc->nsc_argc; i++)
Review comment:
change to i = j = 0;?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org