[jira] [Commented] (ACCUMULO-2358) Issue with character encoding of Success returned from Login using Thrift Proxy and NodeJS

["John Vines (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ACCUMULO-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899380#comment-13899380 ] 

John Vines commented on ACCUMULO-2358:
--------------------------------------

This sounds like an issue with Thrift if it's all in the generated code. Or am I not reading this correctly?

> Issue with character encoding of Success returned from Login using Thrift Proxy and NodeJS
> ------------------------------------------------------------------------------------------
>
>                 Key: ACCUMULO-2358
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2358
>             Project: Accumulo
>          Issue Type: Bug
>          Components: client, proxy
>    Affects Versions: 1.5.0
>         Environment: CentOS 6.4, NodeJS 0.10.21, NPM thrift module 0.9.1
>            Reporter: Ryan Knowles
>            Priority: Minor
>
> I recently tried to connect to Accumulo through the Thrift proxy using NodeJS. 
> I was able to successfully send login information to Accumulo and receive back a success, but when I tried to use this success to feed into other functions such as listTables I would receive an Exception.  
> I traced this down to the AccumuloProxy.js file that was generated from the proxy.thrift file.  In the AccumuloProxy_login_result.prototype.read function if the ftype == Thrift.Type.STRING then this.success is set to input.readString().  During this readString function the toString is called on the Buffer, but what is returned has characters that are not correctly encoded.  I modified the AccumuloProxy_login_result.prototype.read to call readBinary instead and return the Buffer as success.  I was then able to pass the Buffer into the other functions and correctly get a result.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)