[jira] [Closed] (BEAM-2714) ParDo.getAdditionalInputs() return the input of View.CreatePCollectionView instead of output.

["Thomas Groh (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Groh closed BEAM-2714.
-----------------------------
       Resolution: Not A Problem
    Fix Version/s: Not applicable

This change was made as part of the move to the runner API; there is no PCollectionView object in the runner API, and the additional inputs represented within the PTransform node represent the original PCollections that are used to create the view; getAdditionalInputs reflects this behavior.

> ParDo.getAdditionalInputs() return the input of View.CreatePCollectionView instead of output.
> ---------------------------------------------------------------------------------------------
>
>                 Key: BEAM-2714
>                 URL: https://issues.apache.org/jira/browse/BEAM-2714
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Pei He
>            Assignee: Thomas Groh
>            Priority: Critical
>             Fix For: Not applicable
>
>         Attachments: view-tag.png
>
>
> For example, input-pc -> View.AsIterable -> view.out -> ParDo
> getInputs() in TransformHierarchy.Node for ParDo will return input-pc instead of view.out.
> I think the code here should make sure the output of view is returned:
> https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/values/PCollectionViews.java#L147



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)