You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/06/24 22:51:44 UTC
[GitHub] [kafka] ahuang98 opened a new pull request, #12345: MINOR: Support KRaft in ReplicaFetchTest
ahuang98 opened a new pull request, #12345:
URL: https://github.com/apache/kafka/pull/12345
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji merged pull request #12345: MINOR: Support KRaft in ReplicaFetchTest
Posted by GitBox <gi...@apache.org>.
hachikuji merged PR #12345:
URL: https://github.com/apache/kafka/pull/12345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on a diff in pull request #12345: MINOR: Support KRaft in ReplicaFetchTest
Posted by GitBox <gi...@apache.org>.
hachikuji commented on code in PR #12345:
URL: https://github.com/apache/kafka/pull/12345#discussion_r906510006
##########
core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala:
##########
@@ -18,42 +18,41 @@
package kafka.server
import scala.collection.Seq
-
-import org.junit.jupiter.api.{AfterEach, BeforeEach, Test, TestInfo}
-import kafka.server.QuorumTestHarness
-import kafka.utils.TestUtils
+import org.junit.jupiter.api.AfterEach
+import kafka.utils.{TestInfoUtils, TestUtils}
import TestUtils._
+import kafka.integration.KafkaServerTestHarness
import org.apache.kafka.clients.producer.ProducerRecord
import org.apache.kafka.common.TopicPartition
import org.apache.kafka.common.serialization.StringSerializer
+import org.junit.jupiter.params.ParameterizedTest
+import org.junit.jupiter.params.provider.ValueSource
-class ReplicaFetchTest extends QuorumTestHarness {
- var brokers: Seq[KafkaServer] = null
+class ReplicaFetchTest extends KafkaServerTestHarness {
Review Comment:
Perhaps we could extend from `IntegrationTestHarness` instead? Then we just need to override `brokerCount` and we can get rid of the `generateConfigs` override
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org