You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "hvanhovell (via GitHub)" <gi...@apache.org> on 2023/02/15 01:39:37 UTC
[GitHub] [spark] hvanhovell commented on a diff in pull request #40019: [SPARK-42440][CONNECT] Initial set of Dataframe APIs for Scala Client
hvanhovell commented on code in PR #40019:
URL: https://github.com/apache/spark/pull/40019#discussion_r1106559720
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Column.scala:
##########
@@ -95,6 +97,121 @@ class Column private[sql] (private[sql] val expr: proto.Expression) extends Logg
def name(alias: String): Column = Column { builder =>
builder.getAliasBuilder.addName(alias).setExpr(expr)
}
+
+ /**
+ * Returns a sort expression based on the descending order of the column.
+ * {{{
+ * // Scala
+ * df.sort(df("age").desc)
+ *
+ * // Java
+ * df.sort(df.col("age").desc());
+ * }}}
+ *
+ * @group expr_ops
+ * @since 1.3.0
Review Comment:
yeah will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org