[jira] [Work logged] (GOBBLIN-691) Make compaction implementation format-insensitive

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-691?focusedWorklogId=204874&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-204874 ]

ASF GitHub Bot logged work on GOBBLIN-691:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Feb/19 00:09
            Start Date: 27/Feb/19 00:09
    Worklog Time Spent: 10m 
      Work Description: autumnust commented on pull request #2563: [GOBBLIN-691] Make format-specific component pluggable in compaction 
URL: https://github.com/apache/incubator-gobblin/pull/2563
 
 
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/691) issues and references them in the PR title. 
       - https://issues.apache.org/jira/browse/GOBBLIN-691
   
   
   ### Description
   - As the first step of ORC compaction, this PR tries to make current compaction code insensitive to the data format: Format-specific components should be pluggable: `CompactionJobConfigurator ` becomes the abstract implementation for `CompactionAvroJobConfigurator ` which used to be the component for Avro-specific logic, so that we can implement other formats' configurator to use the same dataset discovery and verification logic.  All changes should be backward compatible. 
   - Put `deprecation` annotation for old compaction implementation. Instead, we should use `CompactionSource` + `MRCompactionTask` to launch MR job. 
   - Fix some of typo while reading thru. code. 
   
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 204874)
            Time Spent: 10m
    Remaining Estimate: 0h

> Make compaction implementation format-insensitive
> -------------------------------------------------
>
>                 Key: GOBBLIN-691
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-691
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Lei Sun
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)