You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "clolov (via GitHub)" <gi...@apache.org> on 2023/05/25 15:37:23 UTC
[GitHub] [kafka] clolov opened a new pull request, #13764: KAFKA-14691; [1/N] Add new fields to OffsetFetchRequest and OffsetFet…
clolov opened a new pull request, #13764:
URL: https://github.com/apache/kafka/pull/13764
This is part 1 of [KAFKA-14691](https://issues.apache.org/jira/browse/KAFKA-14691). I change the JSON files which are used to generate the POJOs used during requests and responses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jolshan commented on pull request #13764: KAFKA-14691; [1/N] Add new fields to OffsetFetchRequest and OffsetFetchResponse
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on PR #13764:
URL: https://github.com/apache/kafka/pull/13764#issuecomment-1563462503
Since this is still under development, can we set the flag to indicate the latest version is unstable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #13764: KAFKA-14691; [1/N] Add new fields to OffsetFetchRequest and OffsetFetchResponse
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #13764:
URL: https://github.com/apache/kafka/pull/13764#issuecomment-1564350280
I have a few comments/questions:
* I am not really comfortable with merging this without the server side implementation. @clolov Is there a strong reason to not do them together?
* I agree with @Hangleton that it may be better to start with adding the TopicId only. This is complicated enough on its own. We can the other fields afterwards.
* I agree with @jolshan that we should set `"latestVersionUnstable": true` while in development.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] clolov commented on pull request #13764: KAFKA-14691; [1/N] Add new fields to OffsetFetchRequest and OffsetFetchResponse
Posted by "clolov (via GitHub)" <gi...@apache.org>.
clolov commented on PR #13764:
URL: https://github.com/apache/kafka/pull/13764#issuecomment-1568117181
> I have a few comments/questions:
>
> 1. I am not really comfortable with merging this without the server side implementation. @clolov Is there a strong reason to not do them together?
>
> 2. I agree with @Hangleton that it may be better to start with adding the TopicId only. This is complicated enough on its own. We can the other fields afterwards.
>
> 3. I agree with @jolshan that we should set `"latestVersionUnstable": true` while in development.
I will accommodate 2 and 3 in subsequent commits. There was no reason for 1 other than splitting the pull request into nicer to review chunks. I am happy with trying to put Request/Respone changes + server side changes + tests in the same pull request similar to https://github.com/apache/kafka/pull/13240.
Thank you all for the reviews!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #13764: KAFKA-14691; [1/N] Add new fields to OffsetFetchRequest and OffsetFetchResponse - WIP
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #13764:
URL: https://github.com/apache/kafka/pull/13764#issuecomment-1741511285
Closing this PR for now as the topic id work will be done later. We can re-open it when we resume the work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Hangleton commented on a diff in pull request #13764: KAFKA-14691; [1/N] Add new fields to OffsetFetchRequest and OffsetFetchResponse
Posted by "Hangleton (via GitHub)" <gi...@apache.org>.
Hangleton commented on code in PR #13764:
URL: https://github.com/apache/kafka/pull/13764#discussion_r1205888922
##########
clients/src/main/resources/common/message/OffsetFetchRequest.json:
##########
@@ -51,8 +57,9 @@
"about": "The group ID."},
{ "name": "Topics", "type": "[]OffsetFetchRequestTopics", "versions": "8+", "nullableVersions": "8+",
"about": "Each topic we would like to fetch offsets for, or null to fetch offsets for all topics.", "fields": [
- { "name": "Name", "type": "string", "versions": "8+", "entityType": "topicName",
+ { "name": "Name", "type": "string", "versions": "0-8", "ignorable": true, "entityType": "topicName",
"about": "The topic name."},
+ { "name": "TopicId", "type": "uuid", "versions": "9+", "ignorable": true, "about": "The unique topic ID" },
Review Comment:
nit: The `"about"` field could be on a new line.
##########
clients/src/main/resources/common/message/OffsetFetchRequest.json:
##########
@@ -33,11 +33,17 @@
// Version 7 is adding the require stable flag.
//
// Version 8 is adding support for fetching offsets for multiple groups at a time
- "validVersions": "0-8",
+ //
+ // Version 9 adds GenerationIdOrMemberEpoch, MemberId and TopicId fields (KIP-848).
+ "validVersions": "0-9",
"flexibleVersions": "6+",
"fields": [
{ "name": "GroupId", "type": "string", "versions": "0-7", "entityType": "groupId",
"about": "The group to fetch offsets for." },
+ { "name": "GenerationIdOrMemberEpoch", "type": "int32", "versions": "9+", "default": "-1", "ignorable": true,
Review Comment:
Do we want to add these fields in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac closed pull request #13764: KAFKA-14691; [1/N] Add new fields to OffsetFetchRequest and OffsetFetchResponse - WIP
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac closed pull request #13764: KAFKA-14691; [1/N] Add new fields to OffsetFetchRequest and OffsetFetchResponse - WIP
URL: https://github.com/apache/kafka/pull/13764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org