You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Aaron Bannert <aa...@clove.org> on 2001/10/11 22:29:27 UTC

[PATCH] some makefile cleanups

In preparation for some bigger APR makefile changes that I'll be making
soon, I noticed that some of the files we reference in the makefile
would be better off rooted in $(top_srcdir). Does this look like the
right thing to do here?

-aaron


Index: Makefile.in
===================================================================
RCS file: /home/cvspublic/apr/Makefile.in,v
retrieving revision 1.55
diff -u -r1.55 Makefile.in
--- Makefile.in	2001/09/14 14:10:05	1.55
+++ Makefile.in	2001/10/11 18:45:18
@@ -39,6 +39,7 @@
 libdir=@libdir@
 includedir=@includedir@
 srcdir=@srcdir@
+top_srcdir=@top_srcdir@
 
 delete-lib:
 	@if test -f $(TARGET_LIB); then \
@@ -52,11 +53,11 @@
 
 install: $(TARGET_LIB)
 	if [ ! -d $(includedir) ]; then \
-	    $(srcdir)/build/mkdir.sh $(includedir); \
+	    $(top_srcdir)/build/mkdir.sh $(includedir); \
 	fi; \
-	cp include/*.h $(includedir); \
+	cp $(top_srcdir)/include/*.h $(includedir); \
 	if [ ! -d $(libdir) ]; then \
-	    $(srcdir)/build/mkdir.sh $(libdir); \
+	    $(top_srcdir)/build/mkdir.sh $(libdir); \
 	fi; \
 	$(LIBTOOL) --mode=install cp $(TARGET_LIB) $(libdir)
 	$(LIBTOOL) --mode=install cp APRVARS $(libdir)
@@ -81,10 +82,10 @@
 	fi
 
 $(TARGET_EXPORTS):
-	$(MKEXPORT) include/*.h > $@
+	$(MKEXPORT) $(top_srcdir)/include/*.h > $@
 
 dox:
-	doxygen docs/doxygen.conf
+	doxygen $(top_srcdir)/docs/doxygen.conf
 
 test: $(TARGET_LIB)
 	(cd test; make clean; make; \

Re: [PATCH] some makefile cleanups

Posted by Ryan Bloom <rb...@covalent.net>.
On Thursday 11 October 2001 01:29 pm, Aaron Bannert wrote:
> In preparation for some bigger APR makefile changes that I'll be making
> soon, I noticed that some of the files we reference in the makefile
> would be better off rooted in $(top_srcdir). Does this look like the
> right thing to do here?

YEs, please commit this.

Ryan


______________________________________________________________
Ryan Bloom				rbb@apache.org
Covalent Technologies			rbb@covalent.net
--------------------------------------------------------------