You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2026/05/14 18:56:32 UTC
[PR] Add SQL as a category in breaking API change policy [datafusion]
alamb opened a new pull request, #22179:
URL: https://github.com/apache/datafusion/pull/22179
## Which issue does this PR close?
- Follow on to https://github.com/apache/datafusion/pull/21743
- Related to https://github.com/apache/datafusion/pull/22102
## Rationale for this change
As we have discovered, sometimes seemingly minor changes in SQL semantics have caused non trivial downstream pain, for example the recent changes to NULL semantics in `ANY/ALL`. See
- https://github.com/apache/datafusion/pull/21743#issuecomment-4412252130
## What changes are included in this PR?
Add a note to the the API guide making it clear that changes to SQL semantics are also API changes too and deserve extra attention.
## Are these changes tested?
By CI
## Are there any user-facing changes?
Clearer API docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add SQL as a category in breaking API change policy [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #22179:
URL: https://github.com/apache/datafusion/pull/22179#discussion_r3243605292
##########
docs/source/contributor-guide/api-health.md:
##########
@@ -43,6 +43,16 @@ Examples of non-breaking changes include:
- Marking a function as deprecated (`#[deprecated]`)
- Adding a new function to a `trait` with a default implementation
+### What is the public SQL API and what is a breaking SQL change?
Review Comment:
The core reason for this API is to add this section
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add SQL as a category in breaking API change policy [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #22179:
URL: https://github.com/apache/datafusion/pull/22179#issuecomment-4481071206
I'll leave this open for a few more days before merging it in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add SQL as a category in breaking API change policy [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #22179:
URL: https://github.com/apache/datafusion/pull/22179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org