You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/16 23:54:05 UTC
[GitHub] [airflow] ferruzzi opened a new pull request #20360: Standardize DynamoDB naming
ferruzzi opened a new pull request #20360:
URL: https://github.com/apache/airflow/pull/20360
Part of https://github.com/apache/airflow/issues/20296
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #20360: Standardize DynamoDB naming
Posted by GitBox <gi...@apache.org>.
eladkal merged pull request #20360:
URL: https://github.com/apache/airflow/pull/20360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20360: Standardize DynamoDB naming
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20360:
URL: https://github.com/apache/airflow/pull/20360#issuecomment-1006385619
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on a change in pull request #20360: Standardize DynamoDB naming
Posted by GitBox <gi...@apache.org>.
ferruzzi commented on a change in pull request #20360:
URL: https://github.com/apache/airflow/pull/20360#discussion_r778457959
##########
File path: airflow/providers/amazon/aws/hooks/dynamodb.py
##########
@@ -18,13 +18,14 @@
"""This module contains the AWS DynamoDB hook"""
+import warnings
from typing import Iterable, List, Optional
from airflow.exceptions import AirflowException
from airflow.providers.amazon.aws.hooks.base_aws import AwsBaseHook
-class AwsDynamoDBHook(AwsBaseHook):
+class DynamoDBHook(AwsBaseHook):
Review comment:
I'm sorry, I don't follow. What needs to be done there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #20360: Standardize DynamoDB naming
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #20360:
URL: https://github.com/apache/airflow/pull/20360#discussion_r778603523
##########
File path: airflow/providers/amazon/aws/hooks/dynamodb.py
##########
@@ -18,13 +18,14 @@
"""This module contains the AWS DynamoDB hook"""
+import warnings
from typing import Iterable, List, Optional
from airflow.exceptions import AirflowException
from airflow.providers.amazon.aws.hooks.base_aws import AwsBaseHook
-class AwsDynamoDBHook(AwsBaseHook):
+class DynamoDBHook(AwsBaseHook):
Review comment:
The entry in deprecated class points contrib to `AwsDynamoDBHook`
This is no longer true. It should point to `DynamoDBHook`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #20360: Standardize DynamoDB naming
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #20360:
URL: https://github.com/apache/airflow/pull/20360#discussion_r771913902
##########
File path: airflow/providers/amazon/aws/hooks/dynamodb.py
##########
@@ -18,13 +18,14 @@
"""This module contains the AWS DynamoDB hook"""
+import warnings
from typing import Iterable, List, Optional
from airflow.exceptions import AirflowException
from airflow.providers.amazon.aws.hooks.base_aws import AwsBaseHook
-class AwsDynamoDBHook(AwsBaseHook):
+class DynamoDBHook(AwsBaseHook):
Review comment:
This require also edit to:
https://github.com/apache/airflow/blob/1baa648e2af124032c2f2752dc0f587ee253a3a9/tests/deprecated_classes.py#L415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org