You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/10/30 17:04:07 UTC
[kudu-CR](branch-1.18.x) [security-itest] stop polluting TEST TMPDIR with logs
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21999
Change subject: [security-itest] stop polluting TEST_TMPDIR with logs
......................................................................
[security-itest] stop polluting TEST_TMPDIR with logs
By default, KuduTest-based scenarios have their FLAGS_log_dir pointed to
the TEST_TMPDIR directory, so if master/tserver is run using the
"kudu master run"/"kudu tserver run" CLI tool, the generated log files
aren't cleaned up. This patch addresses the issue by customizing the
--log_dir flag to keep all the logs under the test's directory which
is automatically removed once the scenario successfully completes.
This patch addresses KUDU-3615, at least partially.
Change-Id: Ib70b8a477beeab82af0ee6b4099114d5482f12cf
Reviewed-on: http://gerrit.cloudera.org:8080/21909
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: KeDeng <kd...@gmail.com>
(cherry picked from commit 446861c68cb3cc5e8ef8caaadf7d8eefc2ec1387)
---
M src/kudu/integration-tests/security-itest.cc
1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/21999/1
--
To view, visit http://gerrit.cloudera.org:8080/21999
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib70b8a477beeab82af0ee6b4099114d5482f12cf
Gerrit-Change-Number: 21999
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR](branch-1.18.x) [security-itest] stop polluting TEST TMPDIR with logs
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21999 )
Change subject: [security-itest] stop polluting TEST_TMPDIR with logs
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/633/
--
To view, visit http://gerrit.cloudera.org:8080/21999
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib70b8a477beeab82af0ee6b4099114d5482f12cf
Gerrit-Change-Number: 21999
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 30 Oct 2024 17:04:14 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) [security-itest] stop polluting TEST TMPDIR with logs
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21999 )
Change subject: [security-itest] stop polluting TEST_TMPDIR with logs
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21999
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib70b8a477beeab82af0ee6b4099114d5482f12cf
Gerrit-Change-Number: 21999
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 01 Nov 2024 00:28:33 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) [security-itest] stop polluting TEST TMPDIR with logs
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21999 )
Change subject: [security-itest] stop polluting TEST_TMPDIR with logs
......................................................................
[security-itest] stop polluting TEST_TMPDIR with logs
By default, KuduTest-based scenarios have their FLAGS_log_dir pointed to
the TEST_TMPDIR directory, so if master/tserver is run using the
"kudu master run"/"kudu tserver run" CLI tool, the generated log files
aren't cleaned up. This patch addresses the issue by customizing the
--log_dir flag to keep all the logs under the test's directory which
is automatically removed once the scenario successfully completes.
This patch addresses KUDU-3615, at least partially.
Change-Id: Ib70b8a477beeab82af0ee6b4099114d5482f12cf
Reviewed-on: http://gerrit.cloudera.org:8080/21909
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: KeDeng <kd...@gmail.com>
(cherry picked from commit 446861c68cb3cc5e8ef8caaadf7d8eefc2ec1387)
Reviewed-on: http://gerrit.cloudera.org:8080/21999
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/integration-tests/security-itest.cc
1 file changed, 14 insertions(+), 0 deletions(-)
Approvals:
Abhishek Chennaka: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/21999
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib70b8a477beeab82af0ee6b4099114d5482f12cf
Gerrit-Change-Number: 21999
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.18.x) [security-itest] stop polluting TEST TMPDIR with logs
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21999 )
Change subject: [security-itest] stop polluting TEST_TMPDIR with logs
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21999
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib70b8a477beeab82af0ee6b4099114d5482f12cf
Gerrit-Change-Number: 21999
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 01 Nov 2024 00:38:03 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) [security-itest] stop polluting TEST TMPDIR with logs
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [security-itest] stop polluting TEST_TMPDIR with logs
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/21999
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ib70b8a477beeab82af0ee6b4099114d5482f12cf
Gerrit-Change-Number: 21999
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.18.x) [security-itest] stop polluting TEST TMPDIR with logs
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21999 )
Change subject: [security-itest] stop polluting TEST_TMPDIR with logs
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/633/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21999
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib70b8a477beeab82af0ee6b4099114d5482f12cf
Gerrit-Change-Number: 21999
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 30 Oct 2024 19:57:58 +0000
Gerrit-HasComments: No