You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/04/21 10:59:07 UTC

[GitHub] [james-project] chibenwa commented on a change in pull request #396: JAMES-3261 ZIP packaging for all Guice servers

chibenwa commented on a change in pull request #396:
URL: https://github.com/apache/james-project/pull/396#discussion_r617431986



##########
File path: dockerfiles/run/guice/memory/Dockerfile
##########
@@ -22,7 +22,10 @@ RUN apt-get update && apt-get install -y unzip
 
 # Get data we need to run James : build results and configuration
 ADD destination/james-server-memory-guice.zip /root
-RUN unzip james-server-memory-guice.zip && cp -r /root/james-server-memory-guice/* /root
+RUN unzip james-server-memory-guice.zip && \
+  cp -r /root/james-server-memory-guice/* /root && \
+  rm james-server-memory-guice.zip && \
+  rm -r james-server-memory-guice

Review comment:
       Yes but it do not change the fact that everything is bundled in  a `james-server-memory-guice`
   
   I tried:
   
   ```
   RUN unzip james-server-memory-guice.zip -d /root && rm james-server-memory-guice.zip
   ```
   
   It deflates:
   
   ```
   Step 6/21 : RUN unzip james-server-memory-guice.zip -d /root && rm james-server-memory-guice.zip
    ---> Running in 4bfb050ef3e1
   Archive:  james-server-memory-guice.zip
      creating: /root/james-server-memory-guice/
      creating: /root/james-server-memory-guice/extensions-jars/
      creating: /root/james-server-memory-guice/conf/
      creating: /root/james-server-memory-guice/james-server-memory-guice.lib/
     inflating: /root/james-server-memory-guice/README.adoc  
     inflating: /root/james-server-memory-guice/conf/jmx.properties  
     inflating: /root/james-server-memory-guice/conf/listeners.xml  
     inflating: /root/james-server-memory-guice/conf/logback.xml  
   ```
   
   And I got the error:
   
   ```
   $ docker run -ti mem
   Error: Unable to access jarfile james-server-memory-guice.jar
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org