You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2023/03/06 04:10:12 UTC

[GitHub] [spark] beliefer opened a new pull request, #40293: [SPARK-42677][SQL] Fix the invalid tests for broadcast hint

beliefer opened a new pull request, #40293:
URL: https://github.com/apache/spark/pull/40293

   ### What changes were proposed in this pull request?
   Currently, there are a lot of test cases for broadcast hint is invalid. Because the data size is smaller than broadcast threshold.
   
   
   ### Why are the changes needed?
   Fix the invalid tests for broadcast hint.
   
   
   ### Does this PR introduce _any_ user-facing change?
   'No'.
   Just modify the test cases.
   
   
   ### How was this patch tested?
   Correct test cases.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] beliefer commented on pull request #40293: [SPARK-42677][SQL][TESTS] Fix the invalid tests for broadcast hint

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #40293:
URL: https://github.com/apache/spark/pull/40293#issuecomment-1455720452

   @hvanhovell @zhengruifeng Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zhengruifeng commented on pull request #40293: [SPARK-42677][SQL][TESTS] Fix the invalid tests for broadcast hint

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #40293:
URL: https://github.com/apache/spark/pull/40293#issuecomment-1455683396

   LGTM, merged into master/3.4


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zhengruifeng closed pull request #40293: [SPARK-42677][SQL][TESTS] Fix the invalid tests for broadcast hint

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #40293: [SPARK-42677][SQL][TESTS] Fix the invalid tests for broadcast hint
URL: https://github.com/apache/spark/pull/40293


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org