You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "yaooqinn (via GitHub)" <gi...@apache.org> on 2025/04/28 07:00:15 UTC
[PR] [VL] Replace wget w/ wget_and_untar to make dependency download more reliable [incubator-gluten]
yaooqinn opened a new pull request, #9444:
URL: https://github.com/apache/incubator-gluten/pull/9444
## What changes were proposed in this pull request?
Using wget_and_untar from upstream that accepts options for download tools
## How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Replace wget w/ wget_and_untar to make dependency download more reliable [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE merged PR #9444:
URL: https://github.com/apache/incubator-gluten/pull/9444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Replace wget w/ wget_and_untar to make dependency download more reliable [incubator-gluten]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #9444:
URL: https://github.com/apache/incubator-gluten/pull/9444#discussion_r2063074763
##########
ep/build-velox/src/setup-centos7.sh:
##########
@@ -163,19 +163,17 @@ function install_boost {
function install_protobuf {
cd "${DEPENDENCY_DIR}"
- wget https://github.com/protocolbuffers/protobuf/releases/download/v21.4/protobuf-all-21.4.tar.gz
- tar -xzf protobuf-all-21.4.tar.gz
- cd protobuf-21.4
+ wget_and_untar https://github.com/protocolbuffers/protobuf/releases/download/v21.4/protobuf-all-21.4.tar.gz protobuf
+ cd protobuf
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Replace wget w/ wget_and_untar to make dependency download more reliable [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on code in PR #9444:
URL: https://github.com/apache/incubator-gluten/pull/9444#discussion_r2063026825
##########
ep/build-velox/src/setup-centos7.sh:
##########
@@ -163,19 +163,17 @@ function install_boost {
function install_protobuf {
cd "${DEPENDENCY_DIR}"
- wget https://github.com/protocolbuffers/protobuf/releases/download/v21.4/protobuf-all-21.4.tar.gz
- tar -xzf protobuf-all-21.4.tar.gz
- cd protobuf-21.4
+ wget_and_untar https://github.com/protocolbuffers/protobuf/releases/download/v21.4/protobuf-all-21.4.tar.gz protobuf
+ cd protobuf
./configure CXXFLAGS="-fPIC" --prefix=/usr/local
make "-j$(nproc)"
$SUDO make install
}
function install_gtest {
cd "${DEPENDENCY_DIR}"
- wget https://github.com/google/googletest/archive/refs/tags/release-1.12.1.tar.gz
- tar -xzf release-1.12.1.tar.gz
- cd googletest-release-1.12.1
+ wget_and_untar https://github.com/google/googletest/archive/refs/tags/release-1.12.1.tar.gz googletest
+ cd googletest
Review Comment:
ditto
##########
ep/build-velox/src/setup-centos7.sh:
##########
@@ -163,19 +163,17 @@ function install_boost {
function install_protobuf {
cd "${DEPENDENCY_DIR}"
- wget https://github.com/protocolbuffers/protobuf/releases/download/v21.4/protobuf-all-21.4.tar.gz
- tar -xzf protobuf-all-21.4.tar.gz
- cd protobuf-21.4
+ wget_and_untar https://github.com/protocolbuffers/protobuf/releases/download/v21.4/protobuf-all-21.4.tar.gz protobuf
+ cd protobuf
Review Comment:
Use ` pushd protobuf`, then add `popd` at the end of this function. Then, we can avoid wrong directory may be possibly used when executing some other functions. See https://github.com/apache/incubator-gluten/pull/9294.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Replace wget w/ wget_and_untar to make dependency download more reliable [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9444:
URL: https://github.com/apache/incubator-gluten/pull/9444#issuecomment-2834172458
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICEGJ-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
https://github.com/apache/incubator-gluten/issues
Then could you also rename ***commit message*** and ***pull request title*** in the following format?
[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
See also:
* [Other pull requests](https://github.com/apache/incubator-gluten/pulls/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Replace wget w/ wget_and_untar to make dependency download more reliable [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on code in PR #9444:
URL: https://github.com/apache/incubator-gluten/pull/9444#discussion_r2063026629
##########
ep/build-velox/src/setup-centos7.sh:
##########
@@ -163,19 +163,17 @@ function install_boost {
function install_protobuf {
cd "${DEPENDENCY_DIR}"
- wget https://github.com/protocolbuffers/protobuf/releases/download/v21.4/protobuf-all-21.4.tar.gz
- tar -xzf protobuf-all-21.4.tar.gz
- cd protobuf-21.4
+ wget_and_untar https://github.com/protocolbuffers/protobuf/releases/download/v21.4/protobuf-all-21.4.tar.gz protobuf
+ cd protobuf
Review Comment:
Use `pushd protobuf`, then add `popd` at the end of this function. Then, we can avoid wrong directory may be possibly used when executing some other functions. See https://github.com/apache/incubator-gluten/pull/9294.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org