You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/11/14 07:27:08 UTC
Review Request 15507: CLOUDSTACK-4835: Update global configuration test
cases failed in master
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15507/
-----------------------------------------------------------
Review request for cloudstack and Koushik Das.
Bugs: CLOUDSTACK-4169, CLOUDSTACK-4835 and CLOUDSTACK-5163
https://issues.apache.org/jira/browse/CLOUDSTACK-4169
https://issues.apache.org/jira/browse/CLOUDSTACK-4835
https://issues.apache.org/jira/browse/CLOUDSTACK-5163
Repository: cloudstack-git
Description
-------
CLOUDSTACK-4835: Update global configuration test cases failed in master
Changes made in update/list configuration API to use ConfigDepot
CLOUDSTACK-4169: Scoped configuraion parameters logic moved to ConfigDepot
CLOUDSTACK-5163: missing parameters in configuration table
pool.storage.capacity.disablethreshold, storage.overprovisioning.factor, pool.storage.allocated.capacity.disablethreshold,
cluster.cpu.allocated.capacity.disablethreshold, cluster.memory.allocated.capacity.disablethreshold
Diffs
-----
api/src/com/cloud/deploy/DeploymentClusterPlanner.java ca73267
api/src/com/cloud/deploy/DeploymentPlanner.java 88cfc74
framework/config/src/org/apache/cloudstack/framework/config/ConfigDepot.java 2fd6efb
framework/config/src/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java 254e6d2
server/src/com/cloud/capacity/CapacityManagerImpl.java 70491bc
server/src/com/cloud/configuration/Config.java bc805b7
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 82256ca
server/src/com/cloud/deploy/FirstFitPlanner.java 64b1124
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java a088a4a
server/src/com/cloud/server/ConfigurationServerImpl.java 8459ada
Diff: https://reviews.apache.org/r/15507/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 15507: CLOUDSTACK-4835: Update global configuration test
cases failed in master
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15507/#review28862
-----------------------------------------------------------
api/src/com/cloud/deploy/DeploymentPlanner.java
<https://reviews.apache.org/r/15507/#comment55923>
Is there any other changes in this file? If not remove it.
framework/config/src/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java
<https://reviews.apache.org/r/15507/#comment55924>
this is not required
- Koushik Das
On Nov. 14, 2013, 7:36 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15507/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2013, 7:36 a.m.)
>
>
> Review request for cloudstack and Koushik Das.
>
>
> Bugs: CLOUDSTACK-4169, CLOUDSTACK-4835 and CLOUDSTACK-5163
> https://issues.apache.org/jira/browse/CLOUDSTACK-4169
> https://issues.apache.org/jira/browse/CLOUDSTACK-4835
> https://issues.apache.org/jira/browse/CLOUDSTACK-5163
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-4835: Update global configuration test cases failed in master
> Changes made in update/list configuration API to use ConfigDepot
>
> CLOUDSTACK-4169: Scoped configuraion parameters logic moved to ConfigDepot
>
> CLOUDSTACK-5163: missing parameters in configuration table
> pool.storage.capacity.disablethreshold, storage.overprovisioning.factor, pool.storage.allocated.capacity.disablethreshold,
> cluster.cpu.allocated.capacity.disablethreshold, cluster.memory.allocated.capacity.disablethreshold
>
>
> Diffs
> -----
>
> api/src/com/cloud/deploy/DeploymentClusterPlanner.java ca73267
> api/src/com/cloud/deploy/DeploymentPlanner.java 88cfc74
> framework/config/src/org/apache/cloudstack/framework/config/ConfigDepot.java 2fd6efb
> framework/config/src/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java 254e6d2
> server/src/com/cloud/capacity/CapacityManagerImpl.java 70491bc
> server/src/com/cloud/configuration/Config.java bc805b7
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 82256ca
> server/src/com/cloud/deploy/FirstFitPlanner.java 64b1124
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java a088a4a
> server/src/com/cloud/server/ConfigurationServerImpl.java 8459ada
> server/test/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java d7ac3f7
>
> Diff: https://reviews.apache.org/r/15507/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 15507: CLOUDSTACK-4835: Update global configuration test
cases failed in master
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15507/#review28951
-----------------------------------------------------------
Commit 52de0dc2cae33831cebb23ed4bb81d8368ed33de in branch refs/heads/4.3 from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=52de0dc ]
CLOUDSTACK-4835: Update global configuration test cases failed in master Changes made in update/list configuration API to use ConfigDepot
CLOUDSTACK-4169: Scoped configuraion parameters logic moved to ConfigDepot
CLOUDSTACK-5163: missing parameters in configuration table
- ASF Subversion and Git Services
On Nov. 14, 2013, 9:25 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15507/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2013, 9:25 a.m.)
>
>
> Review request for cloudstack and Koushik Das.
>
>
> Bugs: CLOUDSTACK-4169, CLOUDSTACK-4835 and CLOUDSTACK-5163
> https://issues.apache.org/jira/browse/CLOUDSTACK-4169
> https://issues.apache.org/jira/browse/CLOUDSTACK-4835
> https://issues.apache.org/jira/browse/CLOUDSTACK-5163
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-4835: Update global configuration test cases failed in master
> Changes made in update/list configuration API to use ConfigDepot
>
> CLOUDSTACK-4169: Scoped configuraion parameters logic moved to ConfigDepot
>
> CLOUDSTACK-5163: missing parameters in configuration table
> pool.storage.capacity.disablethreshold, storage.overprovisioning.factor, pool.storage.allocated.capacity.disablethreshold,
> cluster.cpu.allocated.capacity.disablethreshold, cluster.memory.allocated.capacity.disablethreshold
>
>
> Diffs
> -----
>
> api/src/com/cloud/deploy/DeploymentClusterPlanner.java ca73267
> framework/config/src/org/apache/cloudstack/framework/config/ConfigDepot.java 2fd6efb
> framework/config/src/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java 254e6d2
> server/src/com/cloud/capacity/CapacityManagerImpl.java 70491bc
> server/src/com/cloud/configuration/Config.java bc805b7
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 82256ca
> server/src/com/cloud/deploy/FirstFitPlanner.java 64b1124
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java a088a4a
> server/src/com/cloud/server/ConfigurationServerImpl.java 8459ada
> server/test/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java d7ac3f7
>
> Diff: https://reviews.apache.org/r/15507/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 15507: CLOUDSTACK-4835: Update global configuration test
cases failed in master
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15507/#review28946
-----------------------------------------------------------
Commit c29cd9d3c72e119dc74ee7070c08fc6d88dbdf05 in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c29cd9d ]
CLOUDSTACK-4835: Update global configuration test cases failed in master Changes made in update/list configuration API to use ConfigDepot
CLOUDSTACK-4169: Scoped configuraion parameters logic moved to ConfigDepot
CLOUDSTACK-5163: missing parameters in configuration table
- ASF Subversion and Git Services
On Nov. 14, 2013, 9:25 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15507/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2013, 9:25 a.m.)
>
>
> Review request for cloudstack and Koushik Das.
>
>
> Bugs: CLOUDSTACK-4169, CLOUDSTACK-4835 and CLOUDSTACK-5163
> https://issues.apache.org/jira/browse/CLOUDSTACK-4169
> https://issues.apache.org/jira/browse/CLOUDSTACK-4835
> https://issues.apache.org/jira/browse/CLOUDSTACK-5163
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-4835: Update global configuration test cases failed in master
> Changes made in update/list configuration API to use ConfigDepot
>
> CLOUDSTACK-4169: Scoped configuraion parameters logic moved to ConfigDepot
>
> CLOUDSTACK-5163: missing parameters in configuration table
> pool.storage.capacity.disablethreshold, storage.overprovisioning.factor, pool.storage.allocated.capacity.disablethreshold,
> cluster.cpu.allocated.capacity.disablethreshold, cluster.memory.allocated.capacity.disablethreshold
>
>
> Diffs
> -----
>
> api/src/com/cloud/deploy/DeploymentClusterPlanner.java ca73267
> framework/config/src/org/apache/cloudstack/framework/config/ConfigDepot.java 2fd6efb
> framework/config/src/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java 254e6d2
> server/src/com/cloud/capacity/CapacityManagerImpl.java 70491bc
> server/src/com/cloud/configuration/Config.java bc805b7
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 82256ca
> server/src/com/cloud/deploy/FirstFitPlanner.java 64b1124
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java a088a4a
> server/src/com/cloud/server/ConfigurationServerImpl.java 8459ada
> server/test/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java d7ac3f7
>
> Diff: https://reviews.apache.org/r/15507/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 15507: CLOUDSTACK-4835: Update global configuration test
cases failed in master
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15507/#review28947
-----------------------------------------------------------
Ship it!
Ship It!
- Koushik Das
On Nov. 14, 2013, 9:25 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15507/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2013, 9:25 a.m.)
>
>
> Review request for cloudstack and Koushik Das.
>
>
> Bugs: CLOUDSTACK-4169, CLOUDSTACK-4835 and CLOUDSTACK-5163
> https://issues.apache.org/jira/browse/CLOUDSTACK-4169
> https://issues.apache.org/jira/browse/CLOUDSTACK-4835
> https://issues.apache.org/jira/browse/CLOUDSTACK-5163
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-4835: Update global configuration test cases failed in master
> Changes made in update/list configuration API to use ConfigDepot
>
> CLOUDSTACK-4169: Scoped configuraion parameters logic moved to ConfigDepot
>
> CLOUDSTACK-5163: missing parameters in configuration table
> pool.storage.capacity.disablethreshold, storage.overprovisioning.factor, pool.storage.allocated.capacity.disablethreshold,
> cluster.cpu.allocated.capacity.disablethreshold, cluster.memory.allocated.capacity.disablethreshold
>
>
> Diffs
> -----
>
> api/src/com/cloud/deploy/DeploymentClusterPlanner.java ca73267
> framework/config/src/org/apache/cloudstack/framework/config/ConfigDepot.java 2fd6efb
> framework/config/src/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java 254e6d2
> server/src/com/cloud/capacity/CapacityManagerImpl.java 70491bc
> server/src/com/cloud/configuration/Config.java bc805b7
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 82256ca
> server/src/com/cloud/deploy/FirstFitPlanner.java 64b1124
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java a088a4a
> server/src/com/cloud/server/ConfigurationServerImpl.java 8459ada
> server/test/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java d7ac3f7
>
> Diff: https://reviews.apache.org/r/15507/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 15507: CLOUDSTACK-4835: Update global configuration test
cases failed in master
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15507/
-----------------------------------------------------------
(Updated Nov. 14, 2013, 9:25 a.m.)
Review request for cloudstack and Koushik Das.
Bugs: CLOUDSTACK-4169, CLOUDSTACK-4835 and CLOUDSTACK-5163
https://issues.apache.org/jira/browse/CLOUDSTACK-4169
https://issues.apache.org/jira/browse/CLOUDSTACK-4835
https://issues.apache.org/jira/browse/CLOUDSTACK-5163
Repository: cloudstack-git
Description
-------
CLOUDSTACK-4835: Update global configuration test cases failed in master
Changes made in update/list configuration API to use ConfigDepot
CLOUDSTACK-4169: Scoped configuraion parameters logic moved to ConfigDepot
CLOUDSTACK-5163: missing parameters in configuration table
pool.storage.capacity.disablethreshold, storage.overprovisioning.factor, pool.storage.allocated.capacity.disablethreshold,
cluster.cpu.allocated.capacity.disablethreshold, cluster.memory.allocated.capacity.disablethreshold
Diffs (updated)
-----
api/src/com/cloud/deploy/DeploymentClusterPlanner.java ca73267
framework/config/src/org/apache/cloudstack/framework/config/ConfigDepot.java 2fd6efb
framework/config/src/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java 254e6d2
server/src/com/cloud/capacity/CapacityManagerImpl.java 70491bc
server/src/com/cloud/configuration/Config.java bc805b7
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 82256ca
server/src/com/cloud/deploy/FirstFitPlanner.java 64b1124
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java a088a4a
server/src/com/cloud/server/ConfigurationServerImpl.java 8459ada
server/test/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java d7ac3f7
Diff: https://reviews.apache.org/r/15507/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 15507: CLOUDSTACK-4835: Update global configuration test
cases failed in master
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15507/
-----------------------------------------------------------
(Updated Nov. 14, 2013, 9:15 a.m.)
Review request for cloudstack and Koushik Das.
Bugs: CLOUDSTACK-4169, CLOUDSTACK-4835 and CLOUDSTACK-5163
https://issues.apache.org/jira/browse/CLOUDSTACK-4169
https://issues.apache.org/jira/browse/CLOUDSTACK-4835
https://issues.apache.org/jira/browse/CLOUDSTACK-5163
Repository: cloudstack-git
Description
-------
CLOUDSTACK-4835: Update global configuration test cases failed in master
Changes made in update/list configuration API to use ConfigDepot
CLOUDSTACK-4169: Scoped configuraion parameters logic moved to ConfigDepot
CLOUDSTACK-5163: missing parameters in configuration table
pool.storage.capacity.disablethreshold, storage.overprovisioning.factor, pool.storage.allocated.capacity.disablethreshold,
cluster.cpu.allocated.capacity.disablethreshold, cluster.memory.allocated.capacity.disablethreshold
Diffs (updated)
-----
api/src/com/cloud/deploy/DeploymentClusterPlanner.java ca73267
framework/config/src/org/apache/cloudstack/framework/config/ConfigDepot.java 2fd6efb
framework/config/src/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java 254e6d2
server/src/com/cloud/capacity/CapacityManagerImpl.java 70491bc
server/src/com/cloud/configuration/Config.java bc805b7
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 82256ca
server/src/com/cloud/deploy/FirstFitPlanner.java 64b1124
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java a088a4a
server/src/com/cloud/server/ConfigurationServerImpl.java 8459ada
server/test/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java d7ac3f7
Diff: https://reviews.apache.org/r/15507/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 15507: CLOUDSTACK-4835: Update global configuration test
cases failed in master
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15507/
-----------------------------------------------------------
(Updated Nov. 14, 2013, 7:36 a.m.)
Review request for cloudstack and Koushik Das.
Bugs: CLOUDSTACK-4169, CLOUDSTACK-4835 and CLOUDSTACK-5163
https://issues.apache.org/jira/browse/CLOUDSTACK-4169
https://issues.apache.org/jira/browse/CLOUDSTACK-4835
https://issues.apache.org/jira/browse/CLOUDSTACK-5163
Repository: cloudstack-git
Description
-------
CLOUDSTACK-4835: Update global configuration test cases failed in master
Changes made in update/list configuration API to use ConfigDepot
CLOUDSTACK-4169: Scoped configuraion parameters logic moved to ConfigDepot
CLOUDSTACK-5163: missing parameters in configuration table
pool.storage.capacity.disablethreshold, storage.overprovisioning.factor, pool.storage.allocated.capacity.disablethreshold,
cluster.cpu.allocated.capacity.disablethreshold, cluster.memory.allocated.capacity.disablethreshold
Diffs (updated)
-----
api/src/com/cloud/deploy/DeploymentClusterPlanner.java ca73267
api/src/com/cloud/deploy/DeploymentPlanner.java 88cfc74
framework/config/src/org/apache/cloudstack/framework/config/ConfigDepot.java 2fd6efb
framework/config/src/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java 254e6d2
server/src/com/cloud/capacity/CapacityManagerImpl.java 70491bc
server/src/com/cloud/configuration/Config.java bc805b7
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 82256ca
server/src/com/cloud/deploy/FirstFitPlanner.java 64b1124
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java a088a4a
server/src/com/cloud/server/ConfigurationServerImpl.java 8459ada
server/test/org/apache/cloudstack/networkoffering/ChildTestConfiguration.java d7ac3f7
Diff: https://reviews.apache.org/r/15507/diff/
Testing
-------
Thanks,
Harikrishna Patnala