[jira] [Commented] (SPARK-15395) Use getHostString to create RpcAddress

["Shixiong Zhu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-15395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336892#comment-15336892 ] 

Shixiong Zhu commented on SPARK-15395:
--------------------------------------

Just reverted this one for branch 1.6: https://github.com/apache/spark/commit/e530823dd5ddc27436a01f00899679bef2affe5e

> Use getHostString to create RpcAddress
> --------------------------------------
>
>                 Key: SPARK-15395
>                 URL: https://issues.apache.org/jira/browse/SPARK-15395
>             Project: Spark
>          Issue Type: Bug
>    Affects Versions: 1.6.0, 1.6.1
>            Reporter: Shixiong Zhu
>            Assignee: Shixiong Zhu
>             Fix For: 2.0.0
>
>
> Right now the netty RPC uses `InetSocketAddress.getHostName` to create `RpcAddress` for network events. If we use an IP address to connect, then the RpcAddress's host will be a host name (if the reverse lookup successes) instead of the IP address. However, some places need to compare the original IP address and the RpcAddress in `onDisconnect` (e.g., CoarseGrainedExecutorBackend), and this behavior will make the check incorrect.
> The correct way is using `getHostString`.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org