You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/09/29 04:22:57 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #4626: power/battery: Move the enumurate to the common place
xiaoxiang781216 opened a new pull request #4626:
URL: https://github.com/apache/incubator-nuttx/pull/4626
## Summary
so the userspace program can handle the different battery driver equally
## Impact
Same as before
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #4626: power/battery: Move the enumurate to the common place
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #4626:
URL: https://github.com/apache/incubator-nuttx/pull/4626#issuecomment-930161712
Ok, add @masayuki2009 as reviewer too. It's safe If user just use enum value, but not type(e.g. battery_monitor_status_e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #4626: power/battery: Move the enumurate to the common place
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #4626:
URL: https://github.com/apache/incubator-nuttx/pull/4626#issuecomment-930625398
>Ok, add @masayuki2009 as reviewer too. It's safe If user just use enum value, but not type(e.g. battery_monitor_status_e).
I think we need to modify ./sdk/apps/examples/charger/charger_main.c in Spresense SDK.
@SPRESENSE
Do you have any comments on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4626: power/battery: Move the enumurate to the common place
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4626:
URL: https://github.com/apache/incubator-nuttx/pull/4626#issuecomment-930161712
Ok, add @masayuki2009 as reviewer too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on pull request #4626: power/battery: Move the enumurate to the common place
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on pull request #4626:
URL: https://github.com/apache/incubator-nuttx/pull/4626#issuecomment-930154789
I'm okay with the changes, but I believe it is important to get the feedback from @masayuki2009, since it may affect to some extent applications targeting the Spresense platform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] SPRESENSE commented on pull request #4626: power/battery: Move the enumurate to the common place
Posted by GitBox <gi...@apache.org>.
SPRESENSE commented on pull request #4626:
URL: https://github.com/apache/incubator-nuttx/pull/4626#issuecomment-930760392
> @SPRESENSE
> Do you have any comments on this PR?
Thanks for mentioning me.
There is no problem if you update `apps/examples/charger/charger_main.c` at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on pull request #4626: power/battery: Move the enumurate to the common place
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on pull request #4626:
URL: https://github.com/apache/incubator-nuttx/pull/4626#issuecomment-930154789
I'm okay with the changes, but I believe it is important to get the feedback from @masayuki2009, since it may affect to some extent applications targeting the Spresense platform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 merged pull request #4626: power/battery: Move the enumurate to the common place
Posted by GitBox <gi...@apache.org>.
masayuki2009 merged pull request #4626:
URL: https://github.com/apache/incubator-nuttx/pull/4626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #4626: power/battery: Move the enumurate to the common place
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #4626:
URL: https://github.com/apache/incubator-nuttx/pull/4626#issuecomment-930161712
Ok, add @masayuki2009 as reviewer too. It's safe If user just use enum value, but not type(e.g. battery_monitor_status_e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #4626: power/battery: Move the enumurate to the common place
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #4626:
URL: https://github.com/apache/incubator-nuttx/pull/4626#issuecomment-930625398
>Ok, add @masayuki2009 as reviewer too. It's safe If user just use enum value, but not type(e.g. battery_monitor_status_e).
I think we need to modify ./sdk/apps/examples/charger/charger_main.c in Spresense SDK.
@SPRESENSE
Do you have any comments on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4626: power/battery: Move the enumurate to the common place
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4626:
URL: https://github.com/apache/incubator-nuttx/pull/4626#issuecomment-930161712
Ok, add @masayuki2009 as reviewer too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4626: power/battery: Move the enumurate to the common place
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4626:
URL: https://github.com/apache/incubator-nuttx/pull/4626#issuecomment-930799479
Fix here https://github.com/apache/incubator-nuttx-apps/pull/859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org