You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2012/08/21 21:59:03 UTC
[Bug 53758] New: Dynamic Filter Registration mapping logic inverted
https://issues.apache.org/bugzilla/show_bug.cgi?id=53758
Priority: P2
Bug ID: 53758
Assignee: dev@tomcat.apache.org
Summary: Dynamic Filter Registration mapping logic inverted
Severity: major
Classification: Unclassified
OS: All
Reporter: djgraff209@gmail.com
Hardware: All
Status: NEW
Version: trunk
Component: Catalina
Product: Tomcat 7
In the class org.apache.catalina.core.ApplicationFilterRegistration, the
methods addMappingForServletNames and addMappingForUrlPatterns have inverted
logic on how to register the filter to the context.
If the parameter isMatchAfter is passed as true, the filter is placed in the
context using the addFilterMapBefore method.
if (isMatchAfter) {
context.addFilterMapBefore(filterMap);
} else {
context.addFilterMap(filterMap);
}
The logic should ultimate be (in both methods):
if (!isMatchAfter) {
context.addFilterMapBefore(filterMap);
} else {
context.addFilterMap(filterMap);
}
or
if (isMatchAfter) {
context.addFilterMap(filterMap);
} else {
context.addFilterMapBefore(filterMap);
}
svn rev on trunk is 1375614
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 53758] Dynamic Filter Registration mapping logic inverted
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53758
--- Comment #2 from David Graff <dj...@gmail.com> ---
Glad I could help
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 53758] Dynamic Filter Registration mapping logic inverted
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53758
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #1 from Mark Thomas <ma...@apache.org> ---
Thanks for the report and the analysis to pin-point the root cause.
This has been fixed in trunk and 7.0.x and will be included in 7.0.30 onwards.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org