You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "deniskuzZ (via GitHub)" <gi...@apache.org> on 2023/01/27 17:09:15 UTC

[GitHub] [hive] deniskuzZ commented on a diff in pull request #3993: HIVE-26980: Creation of materialized view stored by Iceberg fails if …

deniskuzZ commented on code in PR #3993:
URL: https://github.com/apache/hive/pull/3993#discussion_r1089213321


##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -7878,6 +7878,10 @@ protected Operator genFileSinkPlan(String dest, QB qb, Operator input)
       throw new SemanticException("Unknown destination type: " + destType);
     }
 
+    if (!(destType == QBMetaData.DEST_DFS_FILE && qb.getIsQuery())) {

Review Comment:
   @kasakrisz, could you please elaborate on if condition? what if destType=DEST_LOCAL_FILE?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org