You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:22:15 UTC
[GitHub] [pulsar] wangjialing218 opened a new pull request #10973: [Elasticsearch-sink] support multi Elasticsearch hosts
wangjialing218 opened a new pull request #10973:
URL: https://github.com/apache/pulsar/pull/10973
### Motivation
Current Elasticsearch-sink do not support multi Elasticsearch hosts like "http://172.16.0.1:9200,172.16.0.2:9200"
### Modifications
Add support for multi Elasticsearch hosts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wangjialing218 commented on pull request #10973: [Elasticsearch-sink] support multi Elasticsearch hosts
Posted by GitBox <gi...@apache.org>.
wangjialing218 commented on pull request #10973:
URL: https://github.com/apache/pulsar/pull/10973#issuecomment-880413903
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nlu90 commented on a change in pull request #10973: [Elasticsearch-sink] support multi Elasticsearch hosts
Posted by GitBox <gi...@apache.org>.
nlu90 commented on a change in pull request #10973:
URL: https://github.com/apache/pulsar/pull/10973#discussion_r670802722
##########
File path: pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchSink.java
##########
@@ -139,11 +137,23 @@ private CredentialsProvider getCredentialsProvider() {
return credentialsProvider;
}
- private RestHighLevelClient getClient() throws MalformedURLException {
+ private HttpHost[] getHttpHost() {
Review comment:
nitpick: `getHttpHosts`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wangjialing218 commented on pull request #10973: [Elasticsearch-sink] support multi Elasticsearch hosts
Posted by GitBox <gi...@apache.org>.
wangjialing218 commented on pull request #10973:
URL: https://github.com/apache/pulsar/pull/10973#issuecomment-880523501
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #10973: [Elasticsearch-sink] support multi Elasticsearch hosts
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #10973:
URL: https://github.com/apache/pulsar/pull/10973
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wangjialing218 commented on pull request #10973: [Elasticsearch-sink] support multi Elasticsearch hosts
Posted by GitBox <gi...@apache.org>.
wangjialing218 commented on pull request #10973:
URL: https://github.com/apache/pulsar/pull/10973#issuecomment-864664633
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wangjialing218 commented on pull request #10973: [Elasticsearch-sink] support multi Elasticsearch hosts
Posted by GitBox <gi...@apache.org>.
wangjialing218 commented on pull request #10973:
URL: https://github.com/apache/pulsar/pull/10973#issuecomment-880341416
> Can you add an integration test? https://github.com/apache/pulsar/blob/master/tests/integration/src/test/java/org/apache/pulsar/tests/integration/io/sinks/ElasticSearchSinkTester.java
@tuteng `ElasticSearchSinkTester` use `ElasticSearchContainer` to preform test. The container is one node es, it seems not possible to perfrom multi nodes test there.
I have add the test in `ElasticSearchSinkTests`, and made `ElasticSearchSink.getClient` from private to protected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #10973: [Elasticsearch-sink] support multi Elasticsearch hosts
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #10973:
URL: https://github.com/apache/pulsar/pull/10973#issuecomment-879645792
@freeznet @nlu90 @tuteng can you review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wangjialing218 commented on pull request #10973: [Elasticsearch-sink] support multi Elasticsearch hosts
Posted by GitBox <gi...@apache.org>.
wangjialing218 commented on pull request #10973:
URL: https://github.com/apache/pulsar/pull/10973#issuecomment-881135615
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org