You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2017/03/25 14:15:28 UTC
[GitHub] zeppelin pull request #2189: [branch-0.7] Minor styling for Helium menu
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/2189
[branch-0.7] Minor styling for Helium menu
### What is this PR for?
Since Helium online registry is available in develop version(0.8.0-SNAPSHOT) for now, people only can use their local registry(e.g. `ZEPPELIN_HOME/helium`) in 0.7.X. So they will see below empty screen when open Helium menu at the first time.
<img width="930" alt="screen shot 2017-03-25 at 11 03 20 pm" src="https://cloud.githubusercontent.com/assets/10060731/24322858/4f9c21c6-11af-11e7-93fc-8975dbfcaddf.png">
It's hard to recognize what Helium is and not that attractive actually.
So I added
- initial sentence "Currently there is no available package to be listed" when there is no package under local registry
- question icon to header -> link to https://zeppelin.apache.org/helium_packages.html to give some hint(?) about Helium :)
And also fixed `VISUALIZATION` button group as I did in #2185.
Please see below screenshot images for the details.
### What type of PR is it?
Improvement
### What is the Jira issue?
N/A
### How should this be tested?
1. Run
```
$ yarn run dev
```
under `zeppelin-web/`
2. Go to Helium menu
### Screenshots (if appropriate)
- when the package size is 0 & question mark icon (link to
- fixed viz type icon ordering button group
- before
<img width="126" alt="screen shot 2017-03-25 at 6 46 13 pm" src="https://cloud.githubusercontent.com/assets/10060731/24322931/6dd2e728-11b0-11e7-9b7b-111b751c1dfb.png">
- after (round border in rightmost icon)
<img width="134" alt="screen shot 2017-03-25 at 6 42 24 pm" src="https://cloud.githubusercontent.com/assets/10060731/24322932/6f8c3538-11b0-11e7-8198-a221376f9f44.png">
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin add/initialMsgToHeliumMenu
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2189.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2189
----
commit 39a0775a9e85ad1d4375286d9795dc6745584bb6
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-03-25T09:50:44Z
Minor styling for Heliu menu
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2189: [branch-0.7] Minor styling for Helium menu
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2189
I already merged into `branch-0.7` but not closed yet. So closing this manually.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2189: [branch-0.7] Minor styling for Helium menu
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu closed the pull request at:
https://github.com/apache/zeppelin/pull/2189
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2189: [branch-0.7] Minor styling for Helium menu
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2189
@felixcheung Thanks! Merge into branch-0.7 if there are no further comments on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2189: [branch-0.7] Minor styling for Helium menu
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2189
awesome!
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2189: [branch-0.7] Minor styling for Helium menu
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2189
@felixcheung Is this good to go now? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---