You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2016/01/05 03:46:07 UTC
Review Request 41914: SQOOP-2774 Sqoop2: Remove the notion of
RolesBean
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41914/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-2774
https://issues.apache.org/jira/browse/SQOOP-2774
Repository: sqoop-sqoop2
Description
-------
Removed the class RolesBean.
Diffs
-----
client/src/main/java/org/apache/sqoop/client/request/AuthorizationResourceRequest.java ca05d1b
client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 3109718
common/src/main/java/org/apache/sqoop/json/RoleBean.java ffafddb
common/src/main/java/org/apache/sqoop/json/RolesBean.java c09ba95
common/src/test/java/org/apache/sqoop/json/TestRoleBean.java PRE-CREATION
server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java 1ed63e4
Diff: https://reviews.apache.org/r/41914/diff/
Testing
-------
Added new unit test, integration tests will be executed as part of precommit hook.
Thanks,
Jarek Cecho
Re: Review Request 41914: SQOOP-2774 Sqoop2: Remove the notion of
RolesBean
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41914/
-----------------------------------------------------------
(Updated Jan. 14, 2016, 4:55 p.m.)
Review request for Sqoop.
Changes
-------
Rebase.
Bugs: SQOOP-2774
https://issues.apache.org/jira/browse/SQOOP-2774
Repository: sqoop-sqoop2
Description
-------
Removed the class RolesBean.
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/request/AuthorizationResourceRequest.java e99e913
client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java c962842
common/src/main/java/org/apache/sqoop/json/RoleBean.java ffafddb
common/src/main/java/org/apache/sqoop/json/RolesBean.java c09ba95
common/src/test/java/org/apache/sqoop/json/TestRoleBean.java PRE-CREATION
server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java 45bf4d0
Diff: https://reviews.apache.org/r/41914/diff/
Testing
-------
Added new unit test, integration tests will be executed as part of precommit hook.
Thanks,
Jarek Cecho
Re: Review Request 41914: SQOOP-2774 Sqoop2: Remove the notion of
RolesBean
Posted by Abraham Fine <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41914/#review112914
-----------------------------------------------------------
Ship it!
- Abraham Fine
On Jan. 5, 2016, 2:46 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41914/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 2:46 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2774
> https://issues.apache.org/jira/browse/SQOOP-2774
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Removed the class RolesBean.
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/request/AuthorizationResourceRequest.java ca05d1b
> client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 3109718
> common/src/main/java/org/apache/sqoop/json/RoleBean.java ffafddb
> common/src/main/java/org/apache/sqoop/json/RolesBean.java c09ba95
> common/src/test/java/org/apache/sqoop/json/TestRoleBean.java PRE-CREATION
> server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java 1ed63e4
>
> Diff: https://reviews.apache.org/r/41914/diff/
>
>
> Testing
> -------
>
> Added new unit test, integration tests will be executed as part of precommit hook.
>
>
> Thanks,
>
> Jarek Cecho
>
>