[GitHub] [pulsar] BewareMyPower commented on a change in pull request #12056: [Issue 12040][broker] Multiple bind addresses for Pulsar protocol

[GitBox <gi...@apache.org>]

BewareMyPower commented on a change in pull request #12056:
URL: https://github.com/apache/pulsar/pull/12056#discussion_r711567969



##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -121,13 +121,18 @@
     private String configurationStoreServers;
     @FieldContext(
         category = CATEGORY_SERVER,
-        doc = "The port for serving binary protobuf requests"
+        doc = "The port for serving binary protobuf requests."
+            + "If set, defines a server binding for bindAddress:brokerServicePort"
+            + "without an associated advertised listener."
+            + "The Default value is 6650."
     )
 
     private Optional<Integer> brokerServicePort = Optional.of(6650);
     @FieldContext(
         category = CATEGORY_SERVER,
-        doc = "The port for serving tls secured binary protobuf requests"
+        doc = "The port for serving TLS-secured binary protobuf requests."
+            + "If set, defines a server binding for bindAddress:brokerServicePortTls"
+            + "without an associated advertised listener."
     )

Review comment:
       Maybe we need to add space or newline for each line?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org