You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Ivan Kelly (JIRA)" <ji...@apache.org> on 2010/03/22 15:51:27 UTC
[jira] Created: (ZOOKEEPER-722) zkServer.sh uses sh's builtin echo
on BSD, behaves incorrectly.
zkServer.sh uses sh's builtin echo on BSD, behaves incorrectly.
---------------------------------------------------------------
Key: ZOOKEEPER-722
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-722
Project: Zookeeper
Issue Type: Bug
Components: scripts
Environment: Mac OS X
Reporter: Ivan Kelly
Priority: Minor
zkServer.sh output the PID of the zookeeper process with:
echo -n $! > "$ZOOPIDFILE"
This uses -n which sh's builtin echo does not support. From echo's manpage.
<snip>
Some shells may provide a builtin echo command which is similar or identical to this utility. Most notably, the builtin echo in sh(1) does not accept
the -n option. Consult the builtin(1) manual page.
</snip>
This means that echo -n PID > ZOOPIDFILE will mean the contents of ZOOPIDFILE will be "-n PID". This stops zkServer.sh stop from working correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-722) zkServer.sh uses sh's builtin echo
on BSD, behaves incorrectly.
Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Robinson reassigned ZOOKEEPER-722:
----------------------------------------
Assignee: Henry Robinson (was: Ivan Kelly)
> zkServer.sh uses sh's builtin echo on BSD, behaves incorrectly.
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-722
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-722
> Project: Zookeeper
> Issue Type: Bug
> Components: scripts
> Environment: Mac OS X
> Reporter: Ivan Kelly
> Assignee: Henry Robinson
> Priority: Minor
> Attachments: zk-722.diff
>
>
> zkServer.sh output the PID of the zookeeper process with:
> echo -n $! > "$ZOOPIDFILE"
> This uses -n which sh's builtin echo does not support. From echo's manpage.
> <snip>
> Some shells may provide a builtin echo command which is similar or identical to this utility. Most notably, the builtin echo in sh(1) does not accept
> the -n option. Consult the builtin(1) manual page.
> </snip>
> This means that echo -n PID > ZOOPIDFILE will mean the contents of ZOOPIDFILE will be "-n PID". This stops zkServer.sh stop from working correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-722) zkServer.sh uses sh's builtin echo
on BSD, behaves incorrectly.
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated ZOOKEEPER-722:
---------------------------------
Attachment: zk-722.diff
> zkServer.sh uses sh's builtin echo on BSD, behaves incorrectly.
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-722
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-722
> Project: Zookeeper
> Issue Type: Bug
> Components: scripts
> Environment: Mac OS X
> Reporter: Ivan Kelly
> Priority: Minor
> Attachments: zk-722.diff
>
>
> zkServer.sh output the PID of the zookeeper process with:
> echo -n $! > "$ZOOPIDFILE"
> This uses -n which sh's builtin echo does not support. From echo's manpage.
> <snip>
> Some shells may provide a builtin echo command which is similar or identical to this utility. Most notably, the builtin echo in sh(1) does not accept
> the -n option. Consult the builtin(1) manual page.
> </snip>
> This means that echo -n PID > ZOOPIDFILE will mean the contents of ZOOPIDFILE will be "-n PID". This stops zkServer.sh stop from working correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-722) zkServer.sh uses sh's builtin echo
on BSD, behaves incorrectly.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-722:
--------------------------------------
Assignee: Ivan Kelly
> zkServer.sh uses sh's builtin echo on BSD, behaves incorrectly.
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-722
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-722
> Project: Zookeeper
> Issue Type: Bug
> Components: scripts
> Environment: Mac OS X
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Attachments: zk-722.diff
>
>
> zkServer.sh output the PID of the zookeeper process with:
> echo -n $! > "$ZOOPIDFILE"
> This uses -n which sh's builtin echo does not support. From echo's manpage.
> <snip>
> Some shells may provide a builtin echo command which is similar or identical to this utility. Most notably, the builtin echo in sh(1) does not accept
> the -n option. Consult the builtin(1) manual page.
> </snip>
> This means that echo -n PID > ZOOPIDFILE will mean the contents of ZOOPIDFILE will be "-n PID". This stops zkServer.sh stop from working correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-722) zkServer.sh uses sh's builtin echo
on BSD, behaves incorrectly.
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated ZOOKEEPER-722:
---------------------------------
Attachment: zk-722.diff
Fix by making zk use the echo executable directly when -n in use.
> zkServer.sh uses sh's builtin echo on BSD, behaves incorrectly.
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-722
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-722
> Project: Zookeeper
> Issue Type: Bug
> Components: scripts
> Environment: Mac OS X
> Reporter: Ivan Kelly
> Priority: Minor
> Attachments: zk-722.diff
>
>
> zkServer.sh output the PID of the zookeeper process with:
> echo -n $! > "$ZOOPIDFILE"
> This uses -n which sh's builtin echo does not support. From echo's manpage.
> <snip>
> Some shells may provide a builtin echo command which is similar or identical to this utility. Most notably, the builtin echo in sh(1) does not accept
> the -n option. Consult the builtin(1) manual page.
> </snip>
> This means that echo -n PID > ZOOPIDFILE will mean the contents of ZOOPIDFILE will be "-n PID". This stops zkServer.sh stop from working correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-722) zkServer.sh uses sh's builtin echo
on BSD, behaves incorrectly.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-722:
-----------------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Resolution: Fixed
Patch looks good, verified for linux/cygwin.
> zkServer.sh uses sh's builtin echo on BSD, behaves incorrectly.
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-722
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-722
> Project: Zookeeper
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.3.0
> Environment: Mac OS X
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Fix For: 3.3.1, 3.4.0
>
> Attachments: zk-722.diff
>
>
> zkServer.sh output the PID of the zookeeper process with:
> echo -n $! > "$ZOOPIDFILE"
> This uses -n which sh's builtin echo does not support. From echo's manpage.
> <snip>
> Some shells may provide a builtin echo command which is similar or identical to this utility. Most notably, the builtin echo in sh(1) does not accept
> the -n option. Consult the builtin(1) manual page.
> </snip>
> This means that echo -n PID > ZOOPIDFILE will mean the contents of ZOOPIDFILE will be "-n PID". This stops zkServer.sh stop from working correctly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ZOOKEEPER-722) zkServer.sh uses sh's builtin echo
on BSD, behaves incorrectly.
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated ZOOKEEPER-722:
---------------------------------
Attachment: (was: zk-722.diff)
> zkServer.sh uses sh's builtin echo on BSD, behaves incorrectly.
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-722
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-722
> Project: Zookeeper
> Issue Type: Bug
> Components: scripts
> Environment: Mac OS X
> Reporter: Ivan Kelly
> Priority: Minor
> Attachments: zk-722.diff
>
>
> zkServer.sh output the PID of the zookeeper process with:
> echo -n $! > "$ZOOPIDFILE"
> This uses -n which sh's builtin echo does not support. From echo's manpage.
> <snip>
> Some shells may provide a builtin echo command which is similar or identical to this utility. Most notably, the builtin echo in sh(1) does not accept
> the -n option. Consult the builtin(1) manual page.
> </snip>
> This means that echo -n PID > ZOOPIDFILE will mean the contents of ZOOPIDFILE will be "-n PID". This stops zkServer.sh stop from working correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-722) zkServer.sh uses sh's builtin
echo on BSD, behaves incorrectly.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855859#action_12855859 ]
Patrick Hunt commented on ZOOKEEPER-722:
----------------------------------------
+1 Thanks Ivan!
> zkServer.sh uses sh's builtin echo on BSD, behaves incorrectly.
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-722
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-722
> Project: Zookeeper
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.3.0
> Environment: Mac OS X
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Fix For: 3.3.1, 3.4.0
>
> Attachments: zk-722.diff
>
>
> zkServer.sh output the PID of the zookeeper process with:
> echo -n $! > "$ZOOPIDFILE"
> This uses -n which sh's builtin echo does not support. From echo's manpage.
> <snip>
> Some shells may provide a builtin echo command which is similar or identical to this utility. Most notably, the builtin echo in sh(1) does not accept
> the -n option. Consult the builtin(1) manual page.
> </snip>
> This means that echo -n PID > ZOOPIDFILE will mean the contents of ZOOPIDFILE will be "-n PID". This stops zkServer.sh stop from working correctly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ZOOKEEPER-722) zkServer.sh uses sh's builtin echo
on BSD, behaves incorrectly.
Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Robinson updated ZOOKEEPER-722:
-------------------------------------
Status: Patch Available (was: In Progress)
> zkServer.sh uses sh's builtin echo on BSD, behaves incorrectly.
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-722
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-722
> Project: Zookeeper
> Issue Type: Bug
> Components: scripts
> Environment: Mac OS X
> Reporter: Ivan Kelly
> Assignee: Henry Robinson
> Priority: Minor
> Attachments: zk-722.diff
>
>
> zkServer.sh output the PID of the zookeeper process with:
> echo -n $! > "$ZOOPIDFILE"
> This uses -n which sh's builtin echo does not support. From echo's manpage.
> <snip>
> Some shells may provide a builtin echo command which is similar or identical to this utility. Most notably, the builtin echo in sh(1) does not accept
> the -n option. Consult the builtin(1) manual page.
> </snip>
> This means that echo -n PID > ZOOPIDFILE will mean the contents of ZOOPIDFILE will be "-n PID". This stops zkServer.sh stop from working correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-722) zkServer.sh uses sh's builtin
echo on BSD, behaves incorrectly.
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848209#action_12848209 ]
Ivan Kelly commented on ZOOKEEPER-722:
--------------------------------------
Hi Henry,
I had assumed it used -p1, I've resubmitted the patch now without the
prefixes.
-Ivan
> zkServer.sh uses sh's builtin echo on BSD, behaves incorrectly.
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-722
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-722
> Project: Zookeeper
> Issue Type: Bug
> Components: scripts
> Environment: Mac OS X
> Reporter: Ivan Kelly
> Priority: Minor
> Attachments: zk-722.diff
>
>
> zkServer.sh output the PID of the zookeeper process with:
> echo -n $! > "$ZOOPIDFILE"
> This uses -n which sh's builtin echo does not support. From echo's manpage.
> <snip>
> Some shells may provide a builtin echo command which is similar or identical to this utility. Most notably, the builtin echo in sh(1) does not accept
> the -n option. Consult the builtin(1) manual page.
> </snip>
> This means that echo -n PID > ZOOPIDFILE will mean the contents of ZOOPIDFILE will be "-n PID". This stops zkServer.sh stop from working correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-722) zkServer.sh uses sh's builtin
echo on BSD, behaves incorrectly.
Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848202#action_12848202 ]
Henry Robinson commented on ZOOKEEPER-722:
------------------------------------------
Hi Ivan -
Thanks for the patch - it looks good.
Hudson can't apply it because - I think - you used git diff to generate the patch file which doesn't produce patch -p0 compatible patchfiles. Could you regenerate with git diff --no-prefix and resubmit? Hudson will be able to apply the patch then.
Thanks.
Henry
> zkServer.sh uses sh's builtin echo on BSD, behaves incorrectly.
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-722
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-722
> Project: Zookeeper
> Issue Type: Bug
> Components: scripts
> Environment: Mac OS X
> Reporter: Ivan Kelly
> Priority: Minor
> Attachments: zk-722.diff
>
>
> zkServer.sh output the PID of the zookeeper process with:
> echo -n $! > "$ZOOPIDFILE"
> This uses -n which sh's builtin echo does not support. From echo's manpage.
> <snip>
> Some shells may provide a builtin echo command which is similar or identical to this utility. Most notably, the builtin echo in sh(1) does not accept
> the -n option. Consult the builtin(1) manual page.
> </snip>
> This means that echo -n PID > ZOOPIDFILE will mean the contents of ZOOPIDFILE will be "-n PID". This stops zkServer.sh stop from working correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-722) zkServer.sh uses sh's builtin echo
on BSD, behaves incorrectly.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-722:
-----------------------------------
Affects Version/s: 3.3.0
Fix Version/s: 3.4.0
3.3.1
> zkServer.sh uses sh's builtin echo on BSD, behaves incorrectly.
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-722
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-722
> Project: Zookeeper
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.3.0
> Environment: Mac OS X
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Fix For: 3.3.1, 3.4.0
>
> Attachments: zk-722.diff
>
>
> zkServer.sh output the PID of the zookeeper process with:
> echo -n $! > "$ZOOPIDFILE"
> This uses -n which sh's builtin echo does not support. From echo's manpage.
> <snip>
> Some shells may provide a builtin echo command which is similar or identical to this utility. Most notably, the builtin echo in sh(1) does not accept
> the -n option. Consult the builtin(1) manual page.
> </snip>
> This means that echo -n PID > ZOOPIDFILE will mean the contents of ZOOPIDFILE will be "-n PID". This stops zkServer.sh stop from working correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-722) zkServer.sh uses sh's builtin
echo on BSD, behaves incorrectly.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848418#action_12848418 ]
Hadoop QA commented on ZOOKEEPER-722:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12439471/zk-722.diff
against trunk revision 925362.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/36/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/36/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/36/console
This message is automatically generated.
> zkServer.sh uses sh's builtin echo on BSD, behaves incorrectly.
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-722
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-722
> Project: Zookeeper
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.3.0
> Environment: Mac OS X
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Fix For: 3.3.1, 3.4.0
>
> Attachments: zk-722.diff
>
>
> zkServer.sh output the PID of the zookeeper process with:
> echo -n $! > "$ZOOPIDFILE"
> This uses -n which sh's builtin echo does not support. From echo's manpage.
> <snip>
> Some shells may provide a builtin echo command which is similar or identical to this utility. Most notably, the builtin echo in sh(1) does not accept
> the -n option. Consult the builtin(1) manual page.
> </snip>
> This means that echo -n PID > ZOOPIDFILE will mean the contents of ZOOPIDFILE will be "-n PID". This stops zkServer.sh stop from working correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-722) zkServer.sh uses sh's builtin echo
on BSD, behaves incorrectly.
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated ZOOKEEPER-722:
---------------------------------
Status: In Progress (was: Patch Available)
> zkServer.sh uses sh's builtin echo on BSD, behaves incorrectly.
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-722
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-722
> Project: Zookeeper
> Issue Type: Bug
> Components: scripts
> Environment: Mac OS X
> Reporter: Ivan Kelly
> Priority: Minor
> Attachments: zk-722.diff
>
>
> zkServer.sh output the PID of the zookeeper process with:
> echo -n $! > "$ZOOPIDFILE"
> This uses -n which sh's builtin echo does not support. From echo's manpage.
> <snip>
> Some shells may provide a builtin echo command which is similar or identical to this utility. Most notably, the builtin echo in sh(1) does not accept
> the -n option. Consult the builtin(1) manual page.
> </snip>
> This means that echo -n PID > ZOOPIDFILE will mean the contents of ZOOPIDFILE will be "-n PID". This stops zkServer.sh stop from working correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-722) zkServer.sh uses sh's builtin
echo on BSD, behaves incorrectly.
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848781#action_12848781 ]
Patrick Hunt commented on ZOOKEEPER-722:
----------------------------------------
this is a shell script change, no test for those currently.
Please review for commit, prolly should verify on unix/mac/cygwin.
> zkServer.sh uses sh's builtin echo on BSD, behaves incorrectly.
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-722
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-722
> Project: Zookeeper
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.3.0
> Environment: Mac OS X
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Fix For: 3.3.1, 3.4.0
>
> Attachments: zk-722.diff
>
>
> zkServer.sh output the PID of the zookeeper process with:
> echo -n $! > "$ZOOPIDFILE"
> This uses -n which sh's builtin echo does not support. From echo's manpage.
> <snip>
> Some shells may provide a builtin echo command which is similar or identical to this utility. Most notably, the builtin echo in sh(1) does not accept
> the -n option. Consult the builtin(1) manual page.
> </snip>
> This means that echo -n PID > ZOOPIDFILE will mean the contents of ZOOPIDFILE will be "-n PID". This stops zkServer.sh stop from working correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-722) zkServer.sh uses sh's builtin echo
on BSD, behaves incorrectly.
Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Robinson reassigned ZOOKEEPER-722:
----------------------------------------
Assignee: Ivan Kelly (was: Henry Robinson)
Assigning back to Ivan after I gave Hudson a kick :)
> zkServer.sh uses sh's builtin echo on BSD, behaves incorrectly.
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-722
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-722
> Project: Zookeeper
> Issue Type: Bug
> Components: scripts
> Environment: Mac OS X
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Minor
> Attachments: zk-722.diff
>
>
> zkServer.sh output the PID of the zookeeper process with:
> echo -n $! > "$ZOOPIDFILE"
> This uses -n which sh's builtin echo does not support. From echo's manpage.
> <snip>
> Some shells may provide a builtin echo command which is similar or identical to this utility. Most notably, the builtin echo in sh(1) does not accept
> the -n option. Consult the builtin(1) manual page.
> </snip>
> This means that echo -n PID > ZOOPIDFILE will mean the contents of ZOOPIDFILE will be "-n PID". This stops zkServer.sh stop from working correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-722) zkServer.sh uses sh's builtin echo
on BSD, behaves incorrectly.
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated ZOOKEEPER-722:
---------------------------------
Release Note: Fix zkServer.sh script for BSD systems.
Status: Patch Available (was: Open)
> zkServer.sh uses sh's builtin echo on BSD, behaves incorrectly.
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-722
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-722
> Project: Zookeeper
> Issue Type: Bug
> Components: scripts
> Environment: Mac OS X
> Reporter: Ivan Kelly
> Priority: Minor
> Attachments: zk-722.diff
>
>
> zkServer.sh output the PID of the zookeeper process with:
> echo -n $! > "$ZOOPIDFILE"
> This uses -n which sh's builtin echo does not support. From echo's manpage.
> <snip>
> Some shells may provide a builtin echo command which is similar or identical to this utility. Most notably, the builtin echo in sh(1) does not accept
> the -n option. Consult the builtin(1) manual page.
> </snip>
> This means that echo -n PID > ZOOPIDFILE will mean the contents of ZOOPIDFILE will be "-n PID". This stops zkServer.sh stop from working correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-722) zkServer.sh uses sh's builtin
echo on BSD, behaves incorrectly.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848157#action_12848157 ]
Hadoop QA commented on ZOOKEEPER-722:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12439463/zk-722.diff
against trunk revision 925362.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
-1 patch. The patch command could not apply the patch.
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/35/console
This message is automatically generated.
> zkServer.sh uses sh's builtin echo on BSD, behaves incorrectly.
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-722
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-722
> Project: Zookeeper
> Issue Type: Bug
> Components: scripts
> Environment: Mac OS X
> Reporter: Ivan Kelly
> Priority: Minor
> Attachments: zk-722.diff
>
>
> zkServer.sh output the PID of the zookeeper process with:
> echo -n $! > "$ZOOPIDFILE"
> This uses -n which sh's builtin echo does not support. From echo's manpage.
> <snip>
> Some shells may provide a builtin echo command which is similar or identical to this utility. Most notably, the builtin echo in sh(1) does not accept
> the -n option. Consult the builtin(1) manual page.
> </snip>
> This means that echo -n PID > ZOOPIDFILE will mean the contents of ZOOPIDFILE will be "-n PID". This stops zkServer.sh stop from working correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.