You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by dysmento <gi...@git.apache.org> on 2017/02/13 21:02:45 UTC
[GitHub] tinkerpop pull request #557: TINKERPOP-1633 use official jbcrypt 0.4 in mave...
GitHub user dysmento opened a pull request:
https://github.com/apache/tinkerpop/pull/557
TINKERPOP-1633 use official jbcrypt 0.4 in maven central
targeting tp31 branch for this version bump of jbcrypt to 0.4
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dysmento/tinkerpop tp31
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/557.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #557
----
commit 0fb51e941cafc733419204a7f80b55c30d5387d4
Author: Zach A. Thomas <za...@inin.com>
Date: 2017-02-13T21:01:16Z
TINKERPOP-1633 use official jbcrypt 0.4 in maven central
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #557: TINKERPOP-1633 use official jbcrypt 0.4 in maven centr...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/557
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #557: TINKERPOP-1633 use official jbcrypt 0.4 in mave...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/557#discussion_r101305767
--- Diff: docs/src/reference/gremlin-applications.asciidoc ---
@@ -50,7 +50,6 @@ the defaults. TinkerPop recommends the following configuration in that file:
</filesystem>
<ibiblio name="codehaus" root="http://repository.codehaus.org/" m2compatible="true"/>
--- End diff --
true - i can do that as part of the merge though
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #557: TINKERPOP-1633 use official jbcrypt 0.4 in maven centr...
Posted by robertdale <gi...@git.apache.org>.
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/557
transferring my vote from #556
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #557: TINKERPOP-1633 use official jbcrypt 0.4 in mave...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/557
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #557: TINKERPOP-1633 use official jbcrypt 0.4 in maven centr...
Posted by dysmento <gi...@git.apache.org>.
Github user dysmento commented on the issue:
https://github.com/apache/tinkerpop/pull/557
all set.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #557: TINKERPOP-1633 use official jbcrypt 0.4 in maven centr...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/557
I've had some time to review this. I have a few additional tweaks if you don't mind. In the pom.xml you edited you can removed this `<repository>`:
```xml
<repository>
<id>jitpack.io</id>
<url>https://jitpack.io</url>
</repository>
```
You can also remove this entry in the docs:
https://github.com/apache/tinkerpop/blame/2decc8132ff8726e35e722b8b35475dfa4b2b47c/docs/src/reference/gremlin-applications.asciidoc#L53
There is an entry in `grapeConfig.xml` in the docker directories and a second entry on the gremlin-applications.asciidoc, but both look like those changes were added on the tp32 branch and not here on tp31 - I will take care of that stuff after merging your PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #557: TINKERPOP-1633 use official jbcrypt 0.4 in mave...
Posted by pluradj <gi...@git.apache.org>.
Github user pluradj commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/557#discussion_r101305064
--- Diff: docs/src/reference/gremlin-applications.asciidoc ---
@@ -50,7 +50,6 @@ the defaults. TinkerPop recommends the following configuration in that file:
</filesystem>
<ibiblio name="codehaus" root="http://repository.codehaus.org/" m2compatible="true"/>
--- End diff --
We can remove `codehaus` also. It went out of service a couple years ago.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---