[GitHub] [calcite] michaelmior commented on a change in pull request #2031: [CALCITE-4063] Unnest an array of single-item structs causes ClassCastException

[GitBox <gi...@apache.org>]

michaelmior commented on a change in pull request #2031:
URL: https://github.com/apache/calcite/pull/2031#discussion_r442889550



##########
File path: core/src/test/java/org/apache/calcite/test/enumerable/EnumerableUncollectTest.java
##########
@@ -0,0 +1,189 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.calcite.test.enumerable;
+
+import org.apache.calcite.config.CalciteConnectionProperty;
+import org.apache.calcite.config.Lex;
+import org.apache.calcite.test.CalciteAssert;
+
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+
+class EnumerableUncollectTest {
+
+  @Test void simpleUnnestArray() {
+    final String sql = "select * from UNNEST(array[3, 4]) as T2(y)";
+    tester()
+        .query(sql)
+        .returnsUnordered(

Review comment:
       Should these all really be unordered? I'm not sure what other implementations do, but I would have expected array elements to remain in order (same for the tests below).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org