You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2015/08/04 18:27:28 UTC

Review Request 37080: Introduced RecordIO response reader

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37080/
-----------------------------------------------------------

Review request for mesos, Ben Mahler and Vinod Kone.


Repository: mesos


Description
-------

Added a decorator class over the existing Record-IO decoder in stout (MESOS-3067). The decorator accepts a Pipe::Reader thereby abstracting away the record reading logic. The future returns true only when it sees a complete record. This cleaned up the tests as we no longer need to invoke the stout decoder multiple times till we got atleast one element.

Needed for MESOS-2294 testing.


Diffs
-----

  src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
  src/common/recordio_response.hpp PRE-CREATION 
  src/tests/common/recordio_response_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37080/diff/


Testing
-------

make check + added tests.


Thanks,

Anand Mazumdar

Re: Review Request 37080: Introduced RecordIO response reader

Posted by Anand Mazumdar <ma...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37080/
-----------------------------------------------------------

(Updated Aug. 5, 2015, 3:31 p.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
-------

Added the ".hpp" to the makefile ( would be needed by distcheck )


Repository: mesos


Description
-------

Added a decorator class over the existing Record-IO decoder in stout (MESOS-3067). The decorator accepts a Pipe::Reader thereby abstracting away the record reading logic. The future returns true only when it sees a complete record. This cleaned up the tests as we no longer need to invoke the stout decoder multiple times till we got atleast one element.

Needed for MESOS-2294 testing.


Diffs (updated)
-----

  src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec 
  src/common/recordio_response.hpp PRE-CREATION 
  src/tests/common/recordio_response_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37080/diff/


Testing
-------

make check + added tests.


Thanks,

Anand Mazumdar