You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by mi...@apache.org on 2023/07/26 19:31:00 UTC
[superset] branch master updated: fix: Filters alert width (#24801)
This is an automated email from the ASF dual-hosted git repository.
michaelsmolina pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 4b1f1d49d6 fix: Filters alert width (#24801)
4b1f1d49d6 is described below
commit 4b1f1d49d639747b780b1eb15a552d53bb258198
Author: Michael S. Molina <70...@users.noreply.github.com>
AuthorDate: Wed Jul 26 16:30:52 2023 -0300
fix: Filters alert width (#24801)
---
.../nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx | 7 ++++---
.../FiltersConfigModal/Footer/CancelConfirmationAlert.tsx | 1 +
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx
index 26db1c9a97..a1e600ad20 100644
--- a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx
+++ b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx
@@ -63,12 +63,13 @@ import {
import DividerConfigForm from './DividerConfigForm';
const MODAL_MARGIN = 16;
+const MIN_WIDTH = 880;
const StyledModalWrapper = styled(StyledModal)<{ expanded: boolean }>`
- min-width: 880px;
- width: ${({ expanded }) => (expanded ? '100%' : '70%')} !important;
+ min-width: ${MIN_WIDTH}px;
+ width: ${({ expanded }) => (expanded ? '100%' : MIN_WIDTH)} !important;
- @media (max-width: ${880 + MODAL_MARGIN * 2}px) {
+ @media (max-width: ${MIN_WIDTH + MODAL_MARGIN * 2}px) {
width: 100% !important;
min-width: auto;
}
diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/Footer/CancelConfirmationAlert.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/Footer/CancelConfirmationAlert.tsx
index ba48f698a1..f080ed2b4f 100644
--- a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/Footer/CancelConfirmationAlert.tsx
+++ b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/Footer/CancelConfirmationAlert.tsx
@@ -42,6 +42,7 @@ export function CancelConfirmationAlert({
message={title}
css={{
textAlign: 'left',
+ flex: 1,
'& .ant-alert-action': { alignSelf: 'center' },
}}
description={children}