You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by ms...@apache.org on 2013/02/09 14:01:49 UTC
svn commit: r1444357 - in /flex/falcon/trunk:
compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/
compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/
compiler.jx/src/org/apache/flex/compiler/internal/as/codegen/
Author: mschmalle
Date: Sat Feb 9 13:01:49 2013
New Revision: 1444357
URL: http://svn.apache.org/r1444357
Log:
Flex:FalconJx
- Fixed bug in literal container production, missing space after comma
Modified:
flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestExpressions.java
flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestGlobalClasses.java
flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestGlobalFunctions.java
flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogGlobalClasses.java
flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogGlobalFunctions.java
flex/falcon/trunk/compiler.jx/src/org/apache/flex/compiler/internal/as/codegen/ASEmitter.java
Modified: flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestExpressions.java
URL: http://svn.apache.org/viewvc/flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestExpressions.java?rev=1444357&r1=1444356&r2=1444357&view=diff
==============================================================================
--- flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestExpressions.java (original)
+++ flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestExpressions.java Sat Feb 9 13:01:49 2013
@@ -663,7 +663,7 @@ public class TestExpressions extends Tes
ObjectLiteralNode node = (ObjectLiteralNode) getExpressionNode(
"a = {a:1,b:{c:2,d:{e:4}}}", ObjectLiteralNode.class);
visitor.visitLiteral(node);
- assertOut("{a:1,b:{c:2,d:{e:4}}}");
+ assertOut("{a:1, b:{c:2, d:{e:4}}}");
}
@Test
@@ -672,7 +672,7 @@ public class TestExpressions extends Tes
ArrayLiteralNode node = (ArrayLiteralNode) getExpressionNode(
"a = [0,1,2]", ArrayLiteralNode.class);
visitor.visitLiteral(node);
- assertOut("[0,1,2]");
+ assertOut("[0, 1, 2]");
}
@Test
@@ -681,7 +681,7 @@ public class TestExpressions extends Tes
ArrayLiteralNode node = (ArrayLiteralNode) getExpressionNode(
"a = [0,[0,1,[0,1]],2,[1,2]]", ArrayLiteralNode.class);
visitor.visitLiteral(node);
- assertOut("[0,[0,1,[0,1]],2,[1,2]]");
+ assertOut("[0, [0, 1, [0, 1]], 2, [1, 2]]");
}
@Test
Modified: flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestGlobalClasses.java
URL: http://svn.apache.org/viewvc/flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestGlobalClasses.java?rev=1444357&r1=1444356&r2=1444357&view=diff
==============================================================================
--- flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestGlobalClasses.java (original)
+++ flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestGlobalClasses.java Sat Feb 9 13:01:49 2013
@@ -252,7 +252,7 @@ public class TestGlobalClasses extends T
{
IVariableNode node = getVariable("var a:Vector.<String> = new Vector.<String>(['Hello', 'World']);");
visitor.visitVariable(node);
- assertOut("var a:Vector.<String> = new Vector.<String>(['Hello','World'])");
+ assertOut("var a:Vector.<String> = new Vector.<String>(['Hello', 'World'])");
}
@Test
Modified: flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestGlobalFunctions.java
URL: http://svn.apache.org/viewvc/flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestGlobalFunctions.java?rev=1444357&r1=1444356&r2=1444357&view=diff
==============================================================================
--- flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestGlobalFunctions.java (original)
+++ flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestGlobalFunctions.java Sat Feb 9 13:01:49 2013
@@ -186,7 +186,7 @@ public class TestGlobalFunctions extends
{
IVariableNode node = getVariable("var a:Vector.<String> = Vector.<String>(['Hello', 'World']);");
visitor.visitVariable(node);
- assertOut("var a:Vector.<String> = Vector.<String>(['Hello','World'])");
+ assertOut("var a:Vector.<String> = Vector.<String>(['Hello', 'World'])");
}
@Test
Modified: flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogGlobalClasses.java
URL: http://svn.apache.org/viewvc/flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogGlobalClasses.java?rev=1444357&r1=1444356&r2=1444357&view=diff
==============================================================================
--- flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogGlobalClasses.java (original)
+++ flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogGlobalClasses.java Sat Feb 9 13:01:49 2013
@@ -284,7 +284,7 @@ public class TestGoogGlobalClasses exten
{
IVariableNode node = getVariable("var a:Vector.<String> = new Vector.<String>(['Hello', 'World']);");
visitor.visitVariable(node);
- assertOut("var /** @type {Vector.<string>} */ a = new Vector(['Hello','World'])");
+ assertOut("var /** @type {Vector.<string>} */ a = new Vector(['Hello', 'World'])");
}
@Override
Modified: flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogGlobalFunctions.java
URL: http://svn.apache.org/viewvc/flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogGlobalFunctions.java?rev=1444357&r1=1444356&r2=1444357&view=diff
==============================================================================
--- flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogGlobalFunctions.java (original)
+++ flex/falcon/trunk/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogGlobalFunctions.java Sat Feb 9 13:01:49 2013
@@ -209,7 +209,7 @@ public class TestGoogGlobalFunctions ext
{
IVariableNode node = getVariable("var a:Vector.<String> = Vector.<String>(['Hello', 'World']);");
visitor.visitVariable(node);
- assertOut("var /** @type {Vector.<string>} */ a = Vector(['Hello','World'])");
+ assertOut("var /** @type {Vector.<string>} */ a = Vector(['Hello', 'World'])");
}
@Override
Modified: flex/falcon/trunk/compiler.jx/src/org/apache/flex/compiler/internal/as/codegen/ASEmitter.java
URL: http://svn.apache.org/viewvc/flex/falcon/trunk/compiler.jx/src/org/apache/flex/compiler/internal/as/codegen/ASEmitter.java?rev=1444357&r1=1444356&r2=1444357&view=diff
==============================================================================
--- flex/falcon/trunk/compiler.jx/src/org/apache/flex/compiler/internal/as/codegen/ASEmitter.java (original)
+++ flex/falcon/trunk/compiler.jx/src/org/apache/flex/compiler/internal/as/codegen/ASEmitter.java Sat Feb 9 13:01:49 2013
@@ -1285,7 +1285,7 @@ public class ASEmitter implements IASEmi
IASNode child = node.getChild(i);
getWalker().walk(child);
if (i < len - 1)
- write(COMMA);
+ write(COMMA + SPACE);
}
if (postFix != "")