[GitHub] mhenke1 commented on a change in pull request #2857: Emit metrics via kamon - wip

[gi...@git.apache.org]

mhenke1 commented on a change in pull request #2857: Emit metrics via kamon - wip
URL: https://github.com/apache/incubator-openwhisk/pull/2857#discussion_r145128800
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/common/TransactionId.scala
 ##########
 @@ -55,7 +55,14 @@ case class TransactionId private (meta: TransactionMetadata) extends AnyVal {
    */
   def mark(from: AnyRef, marker: LogMarkerToken, message: String = "", logLevel: LogLevel = InfoLevel)(
     implicit logging: Logging) = {
-    logging.emit(logLevel, this, from, createMessageWithMarker(message, LogMarker(marker, deltaToStart)))
+
+    if (meta.metricsLog) {
+      logging.emit(logLevel, this, from, createMessageWithMarker(message, LogMarker(marker, deltaToStart)))
+    }
 
 Review comment:
   I changed the PR (via amend) to emit simple log message in the original debug level to avoid loss of information. I will tackle log reduction in a following commit
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services