You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/02/21 01:31:34 UTC

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1143: feature: modifying local configuration information is not allowed.

membphis commented on a change in pull request #1143: feature: modifying local configuration information is not allowed.
URL: https://github.com/apache/incubator-apisix/pull/1143#discussion_r382352828
 
 

 ##########
 File path: lua/apisix/core/table.lua
 ##########
 @@ -81,4 +82,18 @@ end
 _M.deepcopy = deepcopy
 
 
+function _M.readonly(t)
 
 Review comment:
   > should it still be possible to modify existing data?
   
   Modification of existing data is not allowed. I'll add new test case to confirm this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services