You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/21 10:45:31 UTC
[GitHub] [doris] starocean999 opened a new pull request, #10311: [bug] fix window function nullable type bug
starocean999 opened a new pull request, #10311:
URL: https://github.com/apache/doris/pull/10311
# Proposed changes
Issue Number: close https://github.com/apache/doris/issues/10308
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (No)
3. Has document been added or modified: (No)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
the output slot of window function is a nullable type, but the function produce non-nullable value. So before return the block to next node, just convert the column to nullable type if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10311: [bug] fix window function nullable type bug
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10311:
URL: https://github.com/apache/doris/pull/10311#issuecomment-1166307739
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10311: [bug] fix window function nullable type bug
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10311:
URL: https://github.com/apache/doris/pull/10311#issuecomment-1166307730
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on pull request #10311: [bug] fix window function nullable type bug
Posted by GitBox <gi...@apache.org>.
HappenLee commented on PR #10311:
URL: https://github.com/apache/doris/pull/10311#issuecomment-1162834340
hello, the problem seems a planner problem. I fix the case in #100340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #10311: [bug] fix window function nullable type bug
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #10311:
URL: https://github.com/apache/doris/pull/10311#issuecomment-1166308081
This is a bottom-line solution, essentially because the FE planner cannot handle such problems well at present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman closed pull request #10311: [bug] fix window function nullable type bug
Posted by GitBox <gi...@apache.org>.
morningman closed pull request #10311: [bug] fix window function nullable type bug
URL: https://github.com/apache/doris/pull/10311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #10311: [bug] fix window function nullable type bug
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #10311:
URL: https://github.com/apache/doris/pull/10311#issuecomment-1169495236
This PR has been merged into dev-1.0.1 as #10430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 commented on a diff in pull request #10311: [bug] fix window function nullable type bug
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on code in PR #10311:
URL: https://github.com/apache/doris/pull/10311#discussion_r902483287
##########
be/src/vec/exec/vanalytic_eval_node.cpp:
##########
@@ -571,7 +571,16 @@ Status VAnalyticEvalNode::_output_current_block(Block* block) {
}
for (size_t i = 0; i < _result_window_columns.size(); ++i) {
- block->insert({std::move(_result_window_columns[i]), _agg_functions[i]->data_type(), ""});
+ SlotDescriptor* output_slot_desc = _output_tuple_desc->slots()[i];
Review Comment:
I think we should fix this bug in another way. Specifically, I think we should figure out why `_agg_functions[i]->data_type()` here is not nullable. Maybe we should change it to nullable in planning phase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org