You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2009/12/08 01:40:18 UTC
[jira] Created: (LANG-561) unescapeHtml has been dropped without
going through deprecation
unescapeHtml has been dropped without going through deprecation
---------------------------------------------------------------
Key: LANG-561
URL: https://issues.apache.org/jira/browse/LANG-561
Project: Commons Lang
Issue Type: Bug
Reporter: Sebb
Fix For: 3.0
The method StringEscapeUtils.unescapeHtml() is missing from version 3.0, yet is not deprecated in 2.4.
As far as I can tell, unescapeHtml is now called unescapeHtml4.
ISTM that unescapeHtml should be reinstated (and deprecated), and perform the same function as Html4.
Another issue - unescapeHtml3 has no Javadoc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LANG-561) unescapeHtml has been dropped without
going through deprecation
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LANG-561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787367#action_12787367 ]
Henri Yandell commented on LANG-561:
------------------------------------
To go further - there should be no deprecated code in Lang 3.0.
> unescapeHtml has been dropped without going through deprecation
> ---------------------------------------------------------------
>
> Key: LANG-561
> URL: https://issues.apache.org/jira/browse/LANG-561
> Project: Commons Lang
> Issue Type: Bug
> Reporter: Sebb
> Fix For: 3.0
>
>
> The method StringEscapeUtils.unescapeHtml() is missing from version 3.0, yet is not deprecated in 2.4.
> As far as I can tell, unescapeHtml is now called unescapeHtml4.
> ISTM that unescapeHtml should be reinstated (and deprecated), and perform the same function as Html4.
> Another issue - unescapeHtml3 has no Javadoc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LANG-561) unescapeHtml has been dropped without
going through deprecation
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LANG-561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787604#action_12787604 ]
Sebb commented on LANG-561:
---------------------------
How about keeping unescapeHtml as an alias for unescapeHtml4 in LANG3?
(With suitable Javadoc).
This would not be the same as keeping deprecated code in LANG3.
I found the problem with the Gump build of JMeter.
There's currently no easy way to fix this, as unescapeHtml4 does not exist in LANG2 and LANG3 has yet to be released.
> unescapeHtml has been dropped without going through deprecation
> ---------------------------------------------------------------
>
> Key: LANG-561
> URL: https://issues.apache.org/jira/browse/LANG-561
> Project: Commons Lang
> Issue Type: Bug
> Reporter: Sebb
> Fix For: 3.0
>
>
> The method StringEscapeUtils.unescapeHtml() is missing from version 3.0, yet is not deprecated in 2.4.
> As far as I can tell, unescapeHtml is now called unescapeHtml4.
> ISTM that unescapeHtml should be reinstated (and deprecated), and perform the same function as Html4.
> Another issue - unescapeHtml3 has no Javadoc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LANG-561) unescapeHtml has been dropped without
going through deprecation
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LANG-561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787366#action_12787366 ]
Henri Yandell commented on LANG-561:
------------------------------------
Agreed that unescapeHtml3 needs Javadoc.
I don't see any reason to deprecate unescapeHtml. There is lots of backwards incompatible changes in Lang, there's no point trying to sugar coat other changes and putting the pain off until later. Better to get it done with now when people are having to go to the work of making their code work.
> unescapeHtml has been dropped without going through deprecation
> ---------------------------------------------------------------
>
> Key: LANG-561
> URL: https://issues.apache.org/jira/browse/LANG-561
> Project: Commons Lang
> Issue Type: Bug
> Reporter: Sebb
> Fix For: 3.0
>
>
> The method StringEscapeUtils.unescapeHtml() is missing from version 3.0, yet is not deprecated in 2.4.
> As far as I can tell, unescapeHtml is now called unescapeHtml4.
> ISTM that unescapeHtml should be reinstated (and deprecated), and perform the same function as Html4.
> Another issue - unescapeHtml3 has no Javadoc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LANG-561) unescapeHtml has been dropped without
going through deprecation
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LANG-561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787657#action_12787657 ]
Niall Pemberton commented on LANG-561:
--------------------------------------
Presumably there is going to be a package name change before Lang 3.0 is released? If so everything breaks.
> unescapeHtml has been dropped without going through deprecation
> ---------------------------------------------------------------
>
> Key: LANG-561
> URL: https://issues.apache.org/jira/browse/LANG-561
> Project: Commons Lang
> Issue Type: Bug
> Reporter: Sebb
> Fix For: 3.0
>
>
> The method StringEscapeUtils.unescapeHtml() is missing from version 3.0, yet is not deprecated in 2.4.
> As far as I can tell, unescapeHtml is now called unescapeHtml4.
> ISTM that unescapeHtml should be reinstated (and deprecated), and perform the same function as Html4.
> Another issue - unescapeHtml3 has no Javadoc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LANG-561) unescapeHtml has been dropped without
going through deprecation
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LANG-561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787255#action_12787255 ]
Paul Benedict commented on LANG-561:
------------------------------------
A 2.4.1 version can be released to deprecate the method appropriately?
> unescapeHtml has been dropped without going through deprecation
> ---------------------------------------------------------------
>
> Key: LANG-561
> URL: https://issues.apache.org/jira/browse/LANG-561
> Project: Commons Lang
> Issue Type: Bug
> Reporter: Sebb
> Fix For: 3.0
>
>
> The method StringEscapeUtils.unescapeHtml() is missing from version 3.0, yet is not deprecated in 2.4.
> As far as I can tell, unescapeHtml is now called unescapeHtml4.
> ISTM that unescapeHtml should be reinstated (and deprecated), and perform the same function as Html4.
> Another issue - unescapeHtml3 has no Javadoc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (LANG-561) unescapeHtml has been dropped without
going through deprecation
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LANG-561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Yandell closed LANG-561.
------------------------------
Resolution: Won't Fix
Closing per Sebb's comment on dev now that the package name has been changed.
> unescapeHtml has been dropped without going through deprecation
> ---------------------------------------------------------------
>
> Key: LANG-561
> URL: https://issues.apache.org/jira/browse/LANG-561
> Project: Commons Lang
> Issue Type: Bug
> Reporter: Sebb
> Fix For: 3.0
>
>
> The method StringEscapeUtils.unescapeHtml() is missing from version 3.0, yet is not deprecated in 2.4.
> As far as I can tell, unescapeHtml is now called unescapeHtml4.
> ISTM that unescapeHtml should be reinstated (and deprecated), and perform the same function as Html4.
> Another issue - unescapeHtml3 has no Javadoc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.