[GitHub] [pulsar] Anonymitaet commented on a change in pull request #14145: [Pulsar-Perf] Allow configuring `metadataStoreUrl` in `pulsar-perf managed-ledger`

[GitBox <gi...@apache.org>]

Anonymitaet commented on a change in pull request #14145:
URL: https://github.com/apache/pulsar/pull/14145#discussion_r801605957



##########
File path: pulsar-testclient/src/main/java/org/apache/pulsar/testclient/ManagedLedgerWriter.java
##########
@@ -98,10 +98,16 @@
                 description = "Number of threads writing", validateWith = PositiveNumberParameterValidator.class)
         public int numThreads = 1;
 
-        @Parameter(names = { "-zk", "--zookeeperServers" },
-                description = "ZooKeeper connection string", required = true)
+        @Deprecated
+        @Parameter(names = {"-zk", "--zookeeperServers"},
+                description = "ZooKeeper connection string",
+                hidden = true)
         public String zookeeperServers;
 
+        @Parameter(names = {"-md",
+                "--metadata-store"}, description = "Metadata store service url. eg: zk:my-zk:2181")

Review comment:
       ```suggestion
                   "--metadata-store"}, description = "Metadata store service URL. For example: zk:my-zk:2181")
   ```
   
   Please capitalize proper nouns correctly. Details: https://docs.google.com/document/d/1lc5j4RtuLIzlEYCBo97AC8-U_3Erzs_lxpkDuseU0n4/edit#bookmark=id.je5thtkj42cb
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org