You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/11/30 00:12:50 UTC
[GitHub] [tvm] tkonolige opened a new pull request #9611: [CMAKE] Automatically detect newly added source files
tkonolige opened a new pull request #9611:
URL: https://github.com/apache/tvm/pull/9611
Before this commit, newly added or removed source files were not detected by cmake. This manifested either as file not found errors from the compiler (when files were deleted) or packedfuncs not being found (when files were added). This commit uses the CONFIGURE_DEPENDS option of cmake's `file(GLOB)` function to ask the build system to check for new files on every rebuild. Checking for new files adds a slight but negligible overhead to each build, but is better than unexpected errors.
Note that the cmake documentation recommends avoiding CONFIGURE_DEPENDS in favor of manually listing all files. This approach has been proposed in the past, but the community did not want to do it.
@electriclilies @junrushao1994 @areusch @jroesch @tqchen @leandron
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige commented on pull request #9611: [CMAKE] Automatically detect newly added source files
Posted by GitBox <gi...@apache.org>.
tkonolige commented on pull request #9611:
URL: https://github.com/apache/tvm/pull/9611#issuecomment-990171168
@areusch Could you review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #9611: [CMAKE] Automatically detect newly added source files
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #9611:
URL: https://github.com/apache/tvm/pull/9611#issuecomment-998253406
@tkonolige Please resolve the conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige commented on pull request #9611: [CMAKE] Automatically detect newly added source files
Posted by GitBox <gi...@apache.org>.
tkonolige commented on pull request #9611:
URL: https://github.com/apache/tvm/pull/9611#issuecomment-984928784
Tested on linux with cmake 3.18 and 3.10 (support for configure_depends was added in 3.12). Are there any more platforms you would like tested? CI should get windows and macOS, but I'm not sure what version there are using.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #9611: [CMAKE] Automatically detect newly added source files
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #9611:
URL: https://github.com/apache/tvm/pull/9611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #9611: [CMAKE] Automatically detect newly added source files
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #9611:
URL: https://github.com/apache/tvm/pull/9611#issuecomment-982224279
Some relevant discussion in cmake forum: https://discourse.cmake.org/t/is-glob-still-considered-harmful-with-configure-depends/808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige edited a comment on pull request #9611: [CMAKE] Automatically detect newly added source files
Posted by GitBox <gi...@apache.org>.
tkonolige edited a comment on pull request #9611:
URL: https://github.com/apache/tvm/pull/9611#issuecomment-990171168
@areusch @junrushao1994 Could you review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #9611: [CMAKE] Automatically detect newly added source files
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #9611:
URL: https://github.com/apache/tvm/pull/9611#issuecomment-1000342762
thanks @tkonolige @areusch @junrushao1994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #9611: [CMAKE] Automatically detect newly added source files
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #9611:
URL: https://github.com/apache/tvm/pull/9611#issuecomment-984920800
@tkonolige which platforms have you tested this on and with what versions of cmake?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org