You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/06 15:44:55 UTC
[GitHub] [shardingsphere] linghengqian opened a new issue, #20963: `spring.factories` should remove the AutoConfiguration class or add new file
linghengqian opened a new issue, #20963:
URL: https://github.com/apache/shardingsphere/issues/20963
## Feature Request
**For English only**, other languages will not accept.
Please pay attention on issues you submitted, because we maybe need more details.
If no response anymore and we cannot make decision by current information, we will **close it**.
Please answer these questions before submitting your issue. Thanks!
### Is your feature request related to a problem?
- No.
### Describe the feature you would like.
- `spring.factories` should remove the `AutoConfiguration` class and keep the others. The feature that `spring.factories` includes `AutoConfiguration` is deprecated in SpringBoot OSS 2.7.0 and removed in Springboot OSS 3.0.0. Refer to https://github.com/spring-projects/spring-boot/issues/29699 .
- Refer to https://github.com/apache/shardingsphere/blob/master/shardingsphere-jdbc/shardingsphere-jdbc-spring/shardingsphere-jdbc-core-spring/shardingsphere-jdbc-core-spring-boot-starter/src/main/resources/META-INF/spring.factories .
- If `spring.factories` is not changed, it will directly break the integration of ShardingSphere SpringBoot Starter and SpringBoot OSS 3.0.0-M5.
- If the project needs to retain support for SpringBoot OSS <= 2.6, it needs to use the processing method of https://github.com/remkop/picocli/pull/1778 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #20963: `spring.factories` should remove the AutoConfiguration class or add new file
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #20963:
URL: https://github.com/apache/shardingsphere/issues/20963#issuecomment-1278890084
Fixed by https://github.com/apache/shardingsphere/pull/21047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian commented on issue #20963: `spring.factories` should remove the AutoConfiguration class or add new file
Posted by GitBox <gi...@apache.org>.
linghengqian commented on issue #20963:
URL: https://github.com/apache/shardingsphere/issues/20963#issuecomment-1272253922
> @terrymanu
>
> - Why does this issue need to be reopened? I have verified at https://github.com/apache/shardingsphere/issues/21225#issuecomment-1267118679 that this PR has resolved the issue.
@zhaojinchao95 Can I close this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu closed issue #20963: `spring.factories` should remove the AutoConfiguration class or add new file
Posted by GitBox <gi...@apache.org>.
strongduanmu closed issue #20963: `spring.factories` should remove the AutoConfiguration class or add new file
URL: https://github.com/apache/shardingsphere/issues/20963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian commented on issue #20963: `spring.factories` should remove the AutoConfiguration class or add new file
Posted by GitBox <gi...@apache.org>.
linghengqian commented on issue #20963:
URL: https://github.com/apache/shardingsphere/issues/20963#issuecomment-1270347022
@terrymanu
- Why does this issue need to be reopened? I have verified at https://github.com/apache/shardingsphere/issues/21225#issuecomment-1267118679 that this PR has resolved the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian commented on issue #20963: `spring.factories` should remove the AutoConfiguration class or add new file
Posted by GitBox <gi...@apache.org>.
linghengqian commented on issue #20963:
URL: https://github.com/apache/shardingsphere/issues/20963#issuecomment-1250196068
- I am working on this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhaojinchao95 closed issue #20963: `spring.factories` should remove the AutoConfiguration class or add new file
Posted by GitBox <gi...@apache.org>.
zhaojinchao95 closed issue #20963: `spring.factories` should remove the AutoConfiguration class or add new file
URL: https://github.com/apache/shardingsphere/issues/20963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org