[GitHub] [incubator-superset] serenajiang opened a new pull request #8619: [fix] TimeTable timelag error

[GitBox <gi...@apache.org>]

serenajiang opened a new pull request #8619: [fix] TimeTable timelag error
URL: https://github.com/apache/incubator-superset/pull/8619
 
 
   ### CATEGORY
   
   Choose one
   
   - [X] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Off by one error 🙃 
   
   We displayed an error about time lags if the time lag was `>` than the length of the data. It should actually be `>=`.
   
   For example, if the time lag is 7 days and there are 7 data points, there should be an error because there are only 6 days in between the first and last day. However, this error was not caught, so users saw:
   
   `An error occurred while rendering the visualization: TypeError: Cannot read property 'Unknown' of undefined`
   
   Fixed viz to include the `=` case.
   
   ### TEST PLAN
   Narrow date range to include $n$ points. Add a comparison column with a time lag of $n$. Ensure that you get the correct error.
   
   ### REVIEWERS
   @graceguo-supercat @michellethomas @etr2460 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org