You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/05/22 01:03:52 UTC

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #14940: Fix warnings and improve inline abuse

haojin2 commented on a change in pull request #14940: Fix warnings and improve inline abuse
URL: https://github.com/apache/incubator-mxnet/pull/14940#discussion_r286278886
 
 

 ##########
 File path: src/operator/nn/dropout-inl.h
 ##########
 @@ -492,7 +492,7 @@ class DropoutOp {
 #endif  // MXNET_USE_CUDNN_DROPOUT
 };  // class DropoutOp
 
-static OpStatePtr CreateDropoutState(const nnvm::NodeAttrs &attrs,
+inline OpStatePtr CreateDropoutState(const nnvm::NodeAttrs &attrs,
 
 Review comment:
   Is this a duplicate fix with #14900 ? Could you merge your changes in that PR into this one here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services