You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/31 16:24:33 UTC

[GitHub] [spark] srowen commented on pull request #36026: [SPARK-38588][ML][FOLLOWUP] fix ga failed at `Bernoulli: check vectors`

srowen commented on pull request #36026:
URL: https://github.com/apache/spark/pull/36026#issuecomment-1084813519


   I see, good catch. The order of checks has changed. I think we actually need two df to test the two conditions now, one that triggers only one type of error each. Otherwise we lose one of the tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org