You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by ul...@apache.org on 2012/01/27 09:20:05 UTC
svn commit: r1236574 -
/tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/OperationAdvisorImpl.java
Author: uli
Date: Fri Jan 27 08:20:05 2012
New Revision: 1236574
URL: http://svn.apache.org/viewvc?rev=1236574&view=rev
Log:
nothing to override here...
Modified:
tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/OperationAdvisorImpl.java
Modified: tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/OperationAdvisorImpl.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/OperationAdvisorImpl.java?rev=1236574&r1=1236573&r2=1236574&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/OperationAdvisorImpl.java (original)
+++ tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/OperationAdvisorImpl.java Fri Jan 27 08:20:05 2012
@@ -39,7 +39,6 @@ public class OperationAdvisorImpl implem
{
return new Runnable()
{
- @Override
public void run()
{
invocation.proceed();
@@ -56,7 +55,6 @@ public class OperationAdvisorImpl implem
this.description = description;
}
- @Override
public void advise(MethodInvocation invocation)
{
tracker.run(description, toRunnable(invocation));
@@ -72,7 +70,6 @@ public class OperationAdvisorImpl implem
this.format = format;
}
- @Override
public void advise(MethodInvocation invocation)
{
Object[] parameters = extractParameters(invocation);
@@ -97,7 +94,6 @@ public class OperationAdvisorImpl implem
}
}
- @Override
public void addOperationAdvice(MethodAdviceReceiver receiver)
{
for (Method m : receiver.getInterface().getMethods())
@@ -114,7 +110,6 @@ public class OperationAdvisorImpl implem
}
}
- @Override
public MethodAdvice createAdvice(String description)
{
assert InternalUtils.isNonBlank(description);
Re: svn commit: r1236574 - /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/OperationAdvisorImpl.java
Posted by Ulrich Stärk <ul...@spielviel.de>.
We already decided on sticking with 1.5 so -1 on @Override on implementations.
Uli
Am 28.01.2012 um 02:22 schrieb Kalle Korhonen <ka...@gmail.com>:
> In practice, keeping the @Overrides means that we'll require 1.6 for
> T5 from that point on. It's only about source compatibility, but then
> we'd need 1.6 to build and so the version bit will go "wrong" (unless
> we add some additional steps to transform the binary back to 1.5
> format). Overall, I'm for requiring 1.6 if we didn't already require
> it before, but just wanted make it clear what's at stake.
>
> Kalle
>
>
> On Fri, Jan 27, 2012 at 3:03 PM, Massimo Lusetti <ml...@gmail.com> wrote:
>> On Fri, Jan 27, 2012 at 11:27 PM, Josh Canfield <jo...@gmail.com> wrote:
>>
>>> +1 for keeping the @Override annotations.
>>
>> Me too... +1 for @Override
>>
>>
>> --
>> Massimo
>> http://meridio.blogspot.com
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
>> For additional commands, e-mail: dev-help@tapestry.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: svn commit: r1236574 - /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/OperationAdvisorImpl.java
Posted by Kalle Korhonen <ka...@gmail.com>.
In practice, keeping the @Overrides means that we'll require 1.6 for
T5 from that point on. It's only about source compatibility, but then
we'd need 1.6 to build and so the version bit will go "wrong" (unless
we add some additional steps to transform the binary back to 1.5
format). Overall, I'm for requiring 1.6 if we didn't already require
it before, but just wanted make it clear what's at stake.
Kalle
On Fri, Jan 27, 2012 at 3:03 PM, Massimo Lusetti <ml...@gmail.com> wrote:
> On Fri, Jan 27, 2012 at 11:27 PM, Josh Canfield <jo...@gmail.com> wrote:
>
>> +1 for keeping the @Override annotations.
>
> Me too... +1 for @Override
>
>
> --
> Massimo
> http://meridio.blogspot.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: svn commit: r1236574 - /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/OperationAdvisorImpl.java
Posted by Massimo Lusetti <ml...@gmail.com>.
On Fri, Jan 27, 2012 at 11:27 PM, Josh Canfield <jo...@gmail.com> wrote:
> +1 for keeping the @Override annotations.
Me too... +1 for @Override
--
Massimo
http://meridio.blogspot.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: svn commit: r1236574 - /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/OperationAdvisorImpl.java
Posted by Josh Canfield <jo...@gmail.com>.
+1 for keeping the @Override annotations.
On Fri, Jan 27, 2012 at 12:48 PM, Howard Lewis Ship <hl...@gmail.com> wrote:
> I'll have to check how I have IDEA set up; it was inserting those.
> @Override on JDK 1.5 is different than 1.6 ... for 1.6 it also means
> implementing an interface method, rather than strictly being an
> override of a base class method.
>
> http://stackoverflow.com/questions/94361/when-do-you-use-javas-override-annotation-and-why
>
> On Fri, Jan 27, 2012 at 12:20 AM, <ul...@apache.org> wrote:
>> Author: uli
>> Date: Fri Jan 27 08:20:05 2012
>> New Revision: 1236574
>>
>> URL: http://svn.apache.org/viewvc?rev=1236574&view=rev
>> Log:
>> nothing to override here...
>>
>> Modified:
>> tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/OperationAdvisorImpl.java
>>
>> Modified: tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/OperationAdvisorImpl.java
>> URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/OperationAdvisorImpl.java?rev=1236574&r1=1236573&r2=1236574&view=diff
>> ==============================================================================
>> --- tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/OperationAdvisorImpl.java (original)
>> +++ tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/OperationAdvisorImpl.java Fri Jan 27 08:20:05 2012
>> @@ -39,7 +39,6 @@ public class OperationAdvisorImpl implem
>> {
>> return new Runnable()
>> {
>> - @Override
>> public void run()
>> {
>> invocation.proceed();
>> @@ -56,7 +55,6 @@ public class OperationAdvisorImpl implem
>> this.description = description;
>> }
>>
>> - @Override
>> public void advise(MethodInvocation invocation)
>> {
>> tracker.run(description, toRunnable(invocation));
>> @@ -72,7 +70,6 @@ public class OperationAdvisorImpl implem
>> this.format = format;
>> }
>>
>> - @Override
>> public void advise(MethodInvocation invocation)
>> {
>> Object[] parameters = extractParameters(invocation);
>> @@ -97,7 +94,6 @@ public class OperationAdvisorImpl implem
>> }
>> }
>>
>> - @Override
>> public void addOperationAdvice(MethodAdviceReceiver receiver)
>> {
>> for (Method m : receiver.getInterface().getMethods())
>> @@ -114,7 +110,6 @@ public class OperationAdvisorImpl implem
>> }
>> }
>>
>> - @Override
>> public MethodAdvice createAdvice(String description)
>> {
>> assert InternalUtils.isNonBlank(description);
>>
>>
>
>
>
> --
> Howard M. Lewis Ship
>
> Creator of Apache Tapestry
>
> The source for Tapestry training, mentoring and support. Contact me to
> learn how I can get you up and productive in Tapestry fast!
>
> (971) 678-5210
> http://howardlewisship.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: svn commit: r1236574 - /tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/OperationAdvisorImpl.java
Posted by Howard Lewis Ship <hl...@gmail.com>.
I'll have to check how I have IDEA set up; it was inserting those.
@Override on JDK 1.5 is different than 1.6 ... for 1.6 it also means
implementing an interface method, rather than strictly being an
override of a base class method.
http://stackoverflow.com/questions/94361/when-do-you-use-javas-override-annotation-and-why
On Fri, Jan 27, 2012 at 12:20 AM, <ul...@apache.org> wrote:
> Author: uli
> Date: Fri Jan 27 08:20:05 2012
> New Revision: 1236574
>
> URL: http://svn.apache.org/viewvc?rev=1236574&view=rev
> Log:
> nothing to override here...
>
> Modified:
> tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/OperationAdvisorImpl.java
>
> Modified: tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/OperationAdvisorImpl.java
> URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/OperationAdvisorImpl.java?rev=1236574&r1=1236573&r2=1236574&view=diff
> ==============================================================================
> --- tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/OperationAdvisorImpl.java (original)
> +++ tapestry/tapestry5/trunk/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/OperationAdvisorImpl.java Fri Jan 27 08:20:05 2012
> @@ -39,7 +39,6 @@ public class OperationAdvisorImpl implem
> {
> return new Runnable()
> {
> - @Override
> public void run()
> {
> invocation.proceed();
> @@ -56,7 +55,6 @@ public class OperationAdvisorImpl implem
> this.description = description;
> }
>
> - @Override
> public void advise(MethodInvocation invocation)
> {
> tracker.run(description, toRunnable(invocation));
> @@ -72,7 +70,6 @@ public class OperationAdvisorImpl implem
> this.format = format;
> }
>
> - @Override
> public void advise(MethodInvocation invocation)
> {
> Object[] parameters = extractParameters(invocation);
> @@ -97,7 +94,6 @@ public class OperationAdvisorImpl implem
> }
> }
>
> - @Override
> public void addOperationAdvice(MethodAdviceReceiver receiver)
> {
> for (Method m : receiver.getInterface().getMethods())
> @@ -114,7 +110,6 @@ public class OperationAdvisorImpl implem
> }
> }
>
> - @Override
> public MethodAdvice createAdvice(String description)
> {
> assert InternalUtils.isNonBlank(description);
>
>
--
Howard M. Lewis Ship
Creator of Apache Tapestry
The source for Tapestry training, mentoring and support. Contact me to
learn how I can get you up and productive in Tapestry fast!
(971) 678-5210
http://howardlewisship.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org