You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "LiBinfeng-01 (via GitHub)" <gi...@apache.org> on 2024/07/19 07:57:37 UTC
[PR] [improvement](Nereids) add where Null rule to create empty relation as where false [doris]
LiBinfeng-01 opened a new pull request, #38135:
URL: https://github.com/apache/doris/pull/38135
explain shape plan select * from table2 where Null;
explain shape plan select * from table2 where false;
in this case, null literal can be regard as same as false literal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](Nereids) add where Null rule to create empty relation as where false [doris]
Posted by "LiBinfeng-01 (via GitHub)" <gi...@apache.org>.
LiBinfeng-01 commented on code in PR #38135:
URL: https://github.com/apache/doris/pull/38135#discussion_r1683982437
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/EliminateFilter.java:
##########
@@ -43,12 +44,13 @@ public class EliminateFilter implements RewriteRuleFactory {
@Override
public List<Rule> buildRules() {
return ImmutableList.of(logicalFilter().when(
- filter -> ExpressionUtils.containsType(filter.getConjuncts(), BooleanLiteral.class))
+ filter -> ExpressionUtils.containsType(filter.getConjuncts(), BooleanLiteral.class)
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](Nereids) add where Null rule to create empty relation as where false [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38135:
URL: https://github.com/apache/doris/pull/38135#issuecomment-2238878581
<details>
<summary>TPC-DS: <b>Total hot run time: 173479 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 06b43c810549d41c2d845305702ee71cf2006251, data reload: false
query1 912 375 358 358
query2 6463 1885 1754 1754
query3 6654 208 213 208
query4 20893 17386 17304 17304
query5 4185 483 468 468
query6 306 205 160 160
query7 4595 283 293 283
query8 239 191 192 191
query9 8528 2465 2438 2438
query10 443 287 272 272
query11 11457 10028 9984 9984
query12 141 86 82 82
query13 1655 385 359 359
query14 10161 8221 7689 7689
query15 215 176 172 172
query16 7659 507 503 503
query17 1571 574 566 566
query18 1371 296 283 283
query19 196 157 157 157
query20 88 82 83 82
query21 209 129 126 126
query22 4258 4087 4105 4087
query23 34072 33343 33274 33274
query24 11868 2845 2897 2845
query25 698 391 390 390
query26 1564 154 153 153
query27 2632 276 277 276
query28 6858 2019 2010 2010
query29 1010 659 633 633
query30 291 149 150 149
query31 998 748 730 730
query32 101 52 55 52
query33 799 351 357 351
query34 902 473 492 473
query35 867 744 758 744
query36 1113 936 932 932
query37 165 82 79 79
query38 2902 2765 2766 2765
query39 838 810 804 804
query40 278 121 126 121
query41 50 50 49 49
query42 124 106 101 101
query43 511 464 461 461
query44 1190 726 731 726
query45 193 166 163 163
query46 1202 790 716 716
query47 1826 1752 1759 1752
query48 363 292 301 292
query49 1168 428 425 425
query50 796 395 399 395
query51 6919 6719 6880 6719
query52 106 96 94 94
query53 367 289 284 284
query54 1117 458 459 458
query55 78 77 75 75
query56 301 299 297 297
query57 1167 1095 1040 1040
query58 269 259 266 259
query59 2847 2625 2684 2625
query60 293 289 271 271
query61 93 91 93 91
query62 827 661 676 661
query63 325 289 288 288
query64 10459 2188 1653 1653
query65 3163 3131 3133 3131
query66 1265 338 337 337
query67 15873 15044 15248 15044
query68 8540 569 551 551
query69 723 443 389 389
query70 1220 1122 1134 1122
query71 526 273 278 273
query72 9222 5309 5561 5309
query73 1220 328 323 323
query74 6567 5721 5651 5651
query75 4612 2689 2713 2689
query76 5230 1002 943 943
query77 774 308 304 304
query78 9608 9188 8994 8994
query79 8321 533 527 527
query80 1125 473 476 473
query81 576 219 226 219
query82 778 136 133 133
query83 335 169 161 161
query84 281 84 84 84
query85 1399 352 305 305
query86 407 286 286 286
query87 3325 3119 3117 3117
query88 4638 2383 2363 2363
query89 522 373 385 373
query90 2003 189 187 187
query91 129 100 99 99
query92 61 48 47 47
query93 6397 529 513 513
query94 1190 301 275 275
query95 406 321 308 308
query96 618 275 267 267
query97 3223 3081 3026 3026
query98 222 213 200 200
query99 1556 1254 1286 1254
Total cold run time: 298801 ms
Total hot run time: 173479 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](Nereids) add where Null rule to create empty relation as where false [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38135:
URL: https://github.com/apache/doris/pull/38135#issuecomment-2242093888
<details>
<summary>ClickBench: <b>Total hot run time: 31.14 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7586b3adff23af8da1b47652330714549e19ec05, data reload: false
query1 0.04 0.04 0.03
query2 0.08 0.04 0.04
query3 0.22 0.06 0.05
query4 1.67 0.08 0.08
query5 0.50 0.47 0.49
query6 1.13 0.72 0.72
query7 0.02 0.01 0.01
query8 0.05 0.04 0.04
query9 0.55 0.49 0.49
query10 0.55 0.54 0.54
query11 0.14 0.11 0.12
query12 0.14 0.13 0.13
query13 0.59 0.58 0.57
query14 0.76 0.78 0.76
query15 0.86 0.81 0.81
query16 0.37 0.37 0.36
query17 1.00 0.96 1.01
query18 0.23 0.22 0.21
query19 1.77 1.82 1.71
query20 0.01 0.01 0.01
query21 15.40 0.77 0.65
query22 4.06 7.20 2.40
query23 18.28 1.46 1.28
query24 2.07 0.21 0.24
query25 0.15 0.08 0.09
query26 0.28 0.21 0.21
query27 0.45 0.23 0.23
query28 13.36 1.01 0.99
query29 12.63 3.32 3.32
query30 0.25 0.06 0.06
query31 2.85 0.39 0.38
query32 3.26 0.48 0.47
query33 2.87 2.94 2.92
query34 17.07 4.42 4.36
query35 4.42 4.41 4.49
query36 0.66 0.48 0.46
query37 0.19 0.16 0.16
query38 0.16 0.15 0.15
query39 0.05 0.03 0.04
query40 0.16 0.13 0.13
query41 0.09 0.05 0.05
query42 0.06 0.05 0.05
query43 0.05 0.04 0.04
Total cold run time: 109.5 s
Total hot run time: 31.14 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](Nereids) add where Null rule to create empty relation as where false [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38135:
URL: https://github.com/apache/doris/pull/38135#issuecomment-2244143667
<details>
<summary>TPC-DS: <b>Total hot run time: 173618 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7586b3adff23af8da1b47652330714549e19ec05, data reload: false
query1 905 367 364 364
query2 6360 1914 1836 1836
query3 6646 208 217 208
query4 27646 17477 17210 17210
query5 3624 470 489 470
query6 255 180 166 166
query7 4614 288 288 288
query8 239 186 194 186
query9 8432 2414 2431 2414
query10 444 291 287 287
query11 12435 10246 10234 10234
query12 122 87 84 84
query13 1639 359 359 359
query14 10145 6939 7992 6939
query15 220 169 168 168
query16 7869 467 519 467
query17 1602 571 536 536
query18 1996 285 301 285
query19 191 151 151 151
query20 102 84 82 82
query21 209 131 125 125
query22 4401 4247 4028 4028
query23 34330 33666 33661 33661
query24 11033 2971 2959 2959
query25 621 412 404 404
query26 912 160 171 160
query27 2279 277 277 277
query28 6282 2057 2035 2035
query29 911 700 651 651
query30 296 158 164 158
query31 974 762 778 762
query32 178 53 55 53
query33 764 330 334 330
query34 874 484 515 484
query35 859 771 763 763
query36 1173 997 962 962
query37 138 82 82 82
query38 2950 2875 2808 2808
query39 953 821 805 805
query40 197 120 116 116
query41 46 42 43 42
query42 117 103 100 100
query43 499 478 478 478
query44 1264 726 738 726
query45 205 162 158 158
query46 1097 702 723 702
query47 1846 1792 1786 1786
query48 359 285 285 285
query49 863 401 408 401
query50 783 389 388 388
query51 6795 6650 6706 6650
query52 105 90 93 90
query53 358 284 290 284
query54 894 447 443 443
query55 73 71 71 71
query56 290 260 264 260
query57 1085 1050 1089 1050
query58 249 250 247 247
query59 2937 2925 2626 2626
query60 288 276 273 273
query61 99 95 92 92
query62 772 649 656 649
query63 326 282 293 282
query64 9221 2216 1657 1657
query65 3140 3091 3105 3091
query66 703 328 335 328
query67 15849 15133 15173 15133
query68 5773 527 530 527
query69 694 433 354 354
query70 1226 1162 1146 1146
query71 471 277 278 277
query72 7881 5433 5613 5433
query73 767 318 315 315
query74 6097 5705 5679 5679
query75 3595 2738 2690 2690
query76 3683 969 903 903
query77 675 327 316 316
query78 10500 9270 9168 9168
query79 3149 513 510 510
query80 2779 484 478 478
query81 586 218 223 218
query82 1133 141 134 134
query83 303 170 165 165
query84 272 91 89 89
query85 1531 307 305 305
query86 472 309 329 309
query87 3427 3122 3114 3114
query88 3946 2347 2365 2347
query89 477 392 381 381
query90 1911 192 193 192
query91 126 100 99 99
query92 62 51 48 48
query93 4088 489 484 484
query94 1257 302 287 287
query95 397 320 312 312
query96 599 277 274 274
query97 3215 3043 2988 2988
query98 216 204 196 196
query99 1752 1260 1231 1231
Total cold run time: 289143 ms
Total hot run time: 173618 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](Nereids) add where Null rule to create empty relation as where false [doris]
Posted by "LiBinfeng-01 (via GitHub)" <gi...@apache.org>.
LiBinfeng-01 commented on PR #38135:
URL: https://github.com/apache/doris/pull/38135#issuecomment-2246996468
run External Regression
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](Nereids) add where Null rule to create empty relation as where false [doris]
Posted by "LiBinfeng-01 (via GitHub)" <gi...@apache.org>.
LiBinfeng-01 commented on PR #38135:
URL: https://github.com/apache/doris/pull/38135#issuecomment-2242052621
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](Nereids) add where Null rule to create empty relation as where false [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38135:
URL: https://github.com/apache/doris/pull/38135#issuecomment-2244148130
<details>
<summary>ClickBench: <b>Total hot run time: 31.15 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7586b3adff23af8da1b47652330714549e19ec05, data reload: false
query1 0.04 0.03 0.03
query2 0.07 0.04 0.04
query3 0.22 0.05 0.05
query4 1.69 0.08 0.08
query5 0.52 0.50 0.49
query6 1.13 0.73 0.74
query7 0.02 0.01 0.01
query8 0.05 0.04 0.04
query9 0.55 0.48 0.50
query10 0.55 0.54 0.54
query11 0.16 0.11 0.11
query12 0.15 0.13 0.12
query13 0.60 0.59 0.58
query14 0.76 0.79 0.77
query15 0.86 0.81 0.80
query16 0.38 0.37 0.35
query17 0.97 0.99 1.02
query18 0.22 0.22 0.21
query19 1.75 1.69 1.73
query20 0.01 0.01 0.01
query21 15.40 0.80 0.66
query22 4.01 6.21 2.42
query23 18.25 1.34 1.27
query24 2.15 0.24 0.22
query25 0.16 0.09 0.09
query26 0.29 0.22 0.21
query27 0.46 0.23 0.23
query28 13.20 1.02 1.01
query29 12.63 3.31 3.28
query30 0.25 0.06 0.05
query31 2.90 0.41 0.40
query32 3.25 0.49 0.47
query33 2.85 2.90 2.92
query34 17.05 4.43 4.37
query35 4.41 4.40 4.43
query36 0.65 0.48 0.47
query37 0.19 0.15 0.16
query38 0.16 0.15 0.14
query39 0.05 0.04 0.04
query40 0.16 0.12 0.14
query41 0.09 0.05 0.05
query42 0.05 0.04 0.05
query43 0.05 0.04 0.04
Total cold run time: 109.36 s
Total hot run time: 31.15 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](Nereids) add where Null rule to create empty relation as where false [doris]
Posted by "LiBinfeng-01 (via GitHub)" <gi...@apache.org>.
LiBinfeng-01 commented on PR #38135:
URL: https://github.com/apache/doris/pull/38135#issuecomment-2244144625
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](Nereids) add where Null rule to create empty relation as where false [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38135:
URL: https://github.com/apache/doris/pull/38135#issuecomment-2244134235
<details>
<summary>TPC-H: <b>Total hot run time: 39821 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7586b3adff23af8da1b47652330714549e19ec05, data reload: false
------ Round 1 ----------------------------------
q1 17617 4300 4261 4261
q2 2011 191 196 191
q3 10448 1222 1049 1049
q4 10180 800 752 752
q5 7542 2670 2637 2637
q6 214 137 136 136
q7 966 604 590 590
q8 9213 2046 2055 2046
q9 8737 6528 6534 6528
q10 8823 3740 3817 3740
q11 452 233 242 233
q12 449 227 224 224
q13 17776 2965 2977 2965
q14 288 232 244 232
q15 521 480 493 480
q16 492 386 392 386
q17 958 663 623 623
q18 7898 7495 7499 7495
q19 7651 1466 1409 1409
q20 680 328 344 328
q21 4882 3236 3849 3236
q22 335 286 280 280
Total cold run time: 118133 ms
Total hot run time: 39821 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4474 4225 4204 4204
q2 376 275 275 275
q3 3006 2895 2919 2895
q4 2010 1699 1777 1699
q5 5580 5529 5478 5478
q6 228 137 132 132
q7 2251 1857 1863 1857
q8 3260 3431 3393 3393
q9 8728 8826 8823 8823
q10 4091 3814 3870 3814
q11 603 513 491 491
q12 831 660 628 628
q13 17060 3151 3191 3151
q14 316 289 289 289
q15 541 471 501 471
q16 500 455 438 438
q17 1781 1516 1499 1499
q18 8248 8069 7902 7902
q19 1754 1568 1553 1553
q20 2807 1881 1882 1881
q21 7444 4689 4872 4689
q22 601 508 536 508
Total cold run time: 76490 ms
Total hot run time: 56070 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](Nereids) add where Null rule to create empty relation as where false [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38135:
URL: https://github.com/apache/doris/pull/38135#issuecomment-2247692990
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](Nereids) add where Null rule to create empty relation as where false [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow merged PR #38135:
URL: https://github.com/apache/doris/pull/38135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](Nereids) add where Null rule to create empty relation as where false [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38135:
URL: https://github.com/apache/doris/pull/38135#issuecomment-2238861667
<details>
<summary>TPC-H: <b>Total hot run time: 40106 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 06b43c810549d41c2d845305702ee71cf2006251, data reload: false
------ Round 1 ----------------------------------
q1 18704 4439 4325 4325
q2 2023 199 194 194
q3 10465 1249 1117 1117
q4 10195 812 797 797
q5 7514 2710 2727 2710
q6 218 135 136 135
q7 944 604 610 604
q8 9213 2067 2054 2054
q9 8646 6541 6602 6541
q10 8648 3746 3797 3746
q11 454 244 249 244
q12 390 231 234 231
q13 17758 2969 3012 2969
q14 275 230 231 230
q15 521 472 490 472
q16 484 390 373 373
q17 963 662 774 662
q18 8076 7411 7405 7405
q19 7322 1436 1499 1436
q20 716 317 331 317
q21 4822 3312 3255 3255
q22 357 289 292 289
Total cold run time: 118708 ms
Total hot run time: 40106 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4414 4276 4257 4257
q2 378 272 259 259
q3 3030 2785 2757 2757
q4 1901 1655 1614 1614
q5 5280 5324 5326 5324
q6 213 128 132 128
q7 2159 1750 1753 1750
q8 3221 3386 3310 3310
q9 8462 8373 8348 8348
q10 3891 3795 3745 3745
q11 600 488 511 488
q12 791 608 587 587
q13 16596 2995 3002 2995
q14 317 274 271 271
q15 508 469 482 469
q16 484 415 411 411
q17 1775 1514 1476 1476
q18 7796 7549 7332 7332
q19 1667 1360 1632 1360
q20 2004 1809 1776 1776
q21 4855 4732 4698 4698
q22 560 531 469 469
Total cold run time: 70902 ms
Total hot run time: 53824 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](Nereids) add where Null rule to create empty relation as where false [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38135:
URL: https://github.com/apache/doris/pull/38135#issuecomment-2242088565
<details>
<summary>TPC-DS: <b>Total hot run time: 171875 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7586b3adff23af8da1b47652330714549e19ec05, data reload: false
query1 907 369 376 369
query2 6445 1792 1778 1778
query3 6661 205 208 205
query4 27911 17357 17112 17112
query5 4185 506 490 490
query6 272 190 171 171
query7 4600 287 285 285
query8 234 199 189 189
query9 8667 2437 2425 2425
query10 432 285 267 267
query11 11950 10067 10001 10001
query12 134 84 85 84
query13 1650 387 382 382
query14 10076 7647 7091 7091
query15 239 168 168 168
query16 7597 492 475 475
query17 1582 566 536 536
query18 1921 288 284 284
query19 199 159 157 157
query20 90 86 88 86
query21 211 133 128 128
query22 4463 4044 4082 4044
query23 33784 33116 33066 33066
query24 11871 2941 2872 2872
query25 657 398 409 398
query26 1848 150 147 147
query27 2894 271 279 271
query28 7459 2016 2007 2007
query29 1087 647 640 640
query30 291 152 151 151
query31 948 750 744 744
query32 98 57 55 55
query33 764 376 340 340
query34 898 480 482 480
query35 842 734 724 724
query36 1105 962 934 934
query37 264 82 83 82
query38 2834 2771 2771 2771
query39 860 810 822 810
query40 285 125 120 120
query41 49 46 46 46
query42 118 100 105 100
query43 504 463 475 463
query44 1216 737 728 728
query45 189 164 165 164
query46 1096 718 750 718
query47 1869 1795 1785 1785
query48 369 290 303 290
query49 1218 435 418 418
query50 787 404 389 389
query51 6816 6664 6732 6664
query52 104 95 94 94
query53 368 293 290 290
query54 1012 446 451 446
query55 79 74 76 74
query56 284 266 276 266
query57 1153 1036 1050 1036
query58 265 239 255 239
query59 2900 2771 2570 2570
query60 303 278 282 278
query61 100 95 98 95
query62 833 661 657 657
query63 320 284 290 284
query64 10533 2264 1650 1650
query65 3187 3109 3146 3109
query66 1427 335 330 330
query67 15687 14842 14965 14842
query68 8563 555 557 555
query69 759 498 382 382
query70 1220 1128 1121 1121
query71 545 286 282 282
query72 9270 5117 5663 5117
query73 1604 324 323 323
query74 6069 5657 5628 5628
query75 5456 2694 2709 2694
query76 5338 942 964 942
query77 774 315 302 302
query78 9734 9087 8981 8981
query79 8215 532 521 521
query80 975 485 536 485
query81 579 220 228 220
query82 777 136 131 131
query83 331 167 164 164
query84 273 83 87 83
query85 1111 321 306 306
query86 420 306 324 306
query87 3297 3109 3087 3087
query88 4802 2349 2369 2349
query89 536 370 372 370
query90 1953 190 189 189
query91 127 101 97 97
query92 59 51 51 51
query93 6676 516 510 510
query94 1193 282 293 282
query95 414 320 318 318
query96 613 270 271 270
query97 3162 3015 3032 3015
query98 215 202 197 197
query99 1542 1242 1233 1233
Total cold run time: 308603 ms
Total hot run time: 171875 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](Nereids) add where Null rule to create empty relation as where false [doris]
Posted by "LiBinfeng-01 (via GitHub)" <gi...@apache.org>.
LiBinfeng-01 commented on PR #38135:
URL: https://github.com/apache/doris/pull/38135#issuecomment-2244098401
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](Nereids) add where Null rule to create empty relation as where false [doris]
Posted by "LiBinfeng-01 (via GitHub)" <gi...@apache.org>.
LiBinfeng-01 commented on PR #38135:
URL: https://github.com/apache/doris/pull/38135#issuecomment-2247100244
./run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](Nereids) add where Null rule to create empty relation as where false [doris]
Posted by "LiBinfeng-01 (via GitHub)" <gi...@apache.org>.
LiBinfeng-01 commented on PR #38135:
URL: https://github.com/apache/doris/pull/38135#issuecomment-2238601905
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](Nereids) add where Null rule to create empty relation as where false [doris]
Posted by "LiBinfeng-01 (via GitHub)" <gi...@apache.org>.
LiBinfeng-01 commented on PR #38135:
URL: https://github.com/apache/doris/pull/38135#issuecomment-2238805605
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](Nereids) add where Null rule to create empty relation as where false [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38135:
URL: https://github.com/apache/doris/pull/38135#issuecomment-2238886028
<details>
<summary>ClickBench: <b>Total hot run time: 31.07 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 06b43c810549d41c2d845305702ee71cf2006251, data reload: false
query1 0.04 0.04 0.04
query2 0.07 0.04 0.04
query3 0.22 0.06 0.06
query4 1.67 0.09 0.07
query5 0.50 0.49 0.50
query6 1.12 0.72 0.72
query7 0.02 0.02 0.02
query8 0.06 0.04 0.04
query9 0.54 0.49 0.50
query10 0.54 0.54 0.55
query11 0.15 0.11 0.12
query12 0.15 0.12 0.13
query13 0.59 0.60 0.59
query14 0.76 0.78 0.78
query15 0.85 0.81 0.81
query16 0.37 0.35 0.35
query17 0.97 0.97 0.94
query18 0.22 0.22 0.22
query19 1.81 1.74 1.68
query20 0.01 0.01 0.01
query21 15.42 0.75 0.67
query22 3.95 6.13 2.23
query23 18.32 1.35 1.35
query24 2.08 0.23 0.25
query25 0.17 0.08 0.09
query26 0.29 0.22 0.21
query27 0.46 0.23 0.23
query28 13.21 1.03 1.01
query29 12.60 3.39 3.33
query30 0.25 0.06 0.05
query31 2.88 0.39 0.38
query32 3.26 0.48 0.48
query33 2.86 2.98 2.90
query34 16.90 4.35 4.36
query35 4.44 4.41 4.44
query36 0.64 0.48 0.47
query37 0.19 0.16 0.15
query38 0.15 0.14 0.14
query39 0.05 0.03 0.03
query40 0.15 0.12 0.12
query41 0.10 0.05 0.05
query42 0.06 0.04 0.05
query43 0.05 0.04 0.04
Total cold run time: 109.14 s
Total hot run time: 31.07 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](Nereids) add where Null rule to create empty relation as where false [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38135:
URL: https://github.com/apache/doris/pull/38135#issuecomment-2242078203
<details>
<summary>TPC-H: <b>Total hot run time: 40099 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7586b3adff23af8da1b47652330714549e19ec05, data reload: false
------ Round 1 ----------------------------------
q1 19335 4646 4358 4358
q2 2031 192 189 189
q3 10476 1173 1122 1122
q4 10198 840 821 821
q5 7551 2780 2693 2693
q6 224 138 137 137
q7 961 592 623 592
q8 9233 2128 2093 2093
q9 8703 6604 6579 6579
q10 8629 3786 3785 3785
q11 452 245 250 245
q12 393 222 217 217
q13 17767 2968 2972 2968
q14 280 230 231 230
q15 532 498 493 493
q16 499 390 386 386
q17 981 715 710 710
q18 8364 7550 7350 7350
q19 6982 1433 1369 1369
q20 676 329 338 329
q21 4910 3151 3301 3151
q22 361 291 282 282
Total cold run time: 119538 ms
Total hot run time: 40099 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4399 4256 4234 4234
q2 372 268 271 268
q3 3009 2816 2832 2816
q4 1905 1598 1596 1596
q5 5326 5356 5339 5339
q6 218 135 131 131
q7 2155 1735 1667 1667
q8 3215 3382 3351 3351
q9 8420 8435 8374 8374
q10 3904 3724 3706 3706
q11 567 487 501 487
q12 765 611 618 611
q13 16689 2961 3017 2961
q14 308 275 264 264
q15 515 475 481 475
q16 480 427 442 427
q17 1784 1501 1459 1459
q18 7775 7401 7365 7365
q19 1665 1533 1477 1477
q20 2031 1799 1777 1777
q21 5088 4906 4795 4795
q22 577 506 518 506
Total cold run time: 71167 ms
Total hot run time: 54086 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](Nereids) add where Null rule to create empty relation as where false [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #38135:
URL: https://github.com/apache/doris/pull/38135#issuecomment-2238589532
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](Nereids) add where Null rule to create empty relation as where false [doris]
Posted by "LiBinfeng-01 (via GitHub)" <gi...@apache.org>.
LiBinfeng-01 commented on PR #38135:
URL: https://github.com/apache/doris/pull/38135#issuecomment-2238589636
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](Nereids) add where Null rule to create empty relation as where false [doris]
Posted by "LiBinfeng-01 (via GitHub)" <gi...@apache.org>.
LiBinfeng-01 commented on PR #38135:
URL: https://github.com/apache/doris/pull/38135#issuecomment-2238817193
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](Nereids) add where Null rule to create empty relation as where false [doris]
Posted by "LiBinfeng-01 (via GitHub)" <gi...@apache.org>.
LiBinfeng-01 commented on PR #38135:
URL: https://github.com/apache/doris/pull/38135#issuecomment-2244720116
run External Regression
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](Nereids) add where Null rule to create empty relation as where false [doris]
Posted by "LiBinfeng-01 (via GitHub)" <gi...@apache.org>.
LiBinfeng-01 commented on PR #38135:
URL: https://github.com/apache/doris/pull/38135#issuecomment-2247007551
run External
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](Nereids) add where Null rule to create empty relation as where false [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38135:
URL: https://github.com/apache/doris/pull/38135#issuecomment-2247693139
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](Nereids) add where Null rule to create empty relation as where false [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #38135:
URL: https://github.com/apache/doris/pull/38135#discussion_r1683977616
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/EliminateFilter.java:
##########
@@ -43,12 +44,13 @@ public class EliminateFilter implements RewriteRuleFactory {
@Override
public List<Rule> buildRules() {
return ImmutableList.of(logicalFilter().when(
- filter -> ExpressionUtils.containsType(filter.getConjuncts(), BooleanLiteral.class))
+ filter -> ExpressionUtils.containsType(filter.getConjuncts(), BooleanLiteral.class)
Review Comment:
add some java ut for this rule
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org