You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/28 02:31:21 UTC

[GitHub] [shardingsphere] dongzl opened a new pull request #7111: Add with segment parser for SQLServer insert statement.

dongzl opened a new pull request #7111:
URL: https://github.com/apache/shardingsphere/pull/7111


   For #6655 .
   For #6478 .
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] dongzl edited a comment on pull request #7111: Add with segment parser for SQLServer insert statement.

Posted by GitBox <gi...@apache.org>.
dongzl edited a comment on pull request #7111:
URL: https://github.com/apache/shardingsphere/pull/7111#issuecomment-683288182


   Hi @tristaZero @jingshanglu , I understand for all the database SQL dialects, they have the same parts and there also will be some differences, we should take the same parts to the parent class, and take the differences to subclass. But split them into different subclasses will need more time, I also suggest we can finish the SQL collation firstly and then consider splitting them.
   
   Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] dongzl commented on pull request #7111: Add with segment parser for SQLServer insert statement.

Posted by GitBox <gi...@apache.org>.
dongzl commented on pull request #7111:
URL: https://github.com/apache/shardingsphere/pull/7111#issuecomment-683288182


   Hi @tristaZero @jingshanglu , I understand for all the database SQL dialects, they have the same parts and there also will be some differences, we should take the same parts to the parent class, and take the differences to subclass. But split them into different subclasses will need more time, I suggest we can finish the SQL collation firstly and then consider splitting them.
   
   Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] jingshanglu merged pull request #7111: Add with segment parser for SQLServer insert statement.

Posted by GitBox <gi...@apache.org>.
jingshanglu merged pull request #7111:
URL: https://github.com/apache/shardingsphere/pull/7111


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] coveralls commented on pull request #7111: Add with segment parser for SQLServer insert statement.

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #7111:
URL: https://github.com/apache/shardingsphere/pull/7111#issuecomment-682298168


   ## Pull Request Test Coverage Report for [Build 14198](https://coveralls.io/builds/33061790)
   
   * **27** of **29**   **(93.1%)**  changed or added relevant lines in **2** files are covered.
   * **4296** unchanged lines in **2** files lost coverage.
   * Overall coverage increased (+**0.06%**) to **35.309%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/sqlserver/visitor/impl/SQLServerDMLVisitor.java](https://coveralls.io/builds/33061790/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsqlserver%2Fvisitor%2Fimpl%2FSQLServerDMLVisitor.java#L195) | 27 | 28 | 96.43%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/InsertStatement.java](https://coveralls.io/builds/33061790/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdml%2FInsertStatement.java#L112) | 0 | 1 | 0.0%
   <!-- | **Total:** | **27** | **29** | **93.1%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/target/generated-sources/antlr4/org/apache/shardingsphere/sql/parser/autogen/SQLServerStatementBaseVisitor.java](https://coveralls.io/builds/33061790/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-sqlserver%2Ftarget%2Fgenerated-sources%2Fantlr4%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fautogen%2FSQLServerStatementBaseVisitor.java#L363) | 3 | 1.18% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/target/generated-sources/antlr4/org/apache/shardingsphere/sql/parser/autogen/SQLServerStatementParser.java](https://coveralls.io/builds/33061790/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-sqlserver%2Ftarget%2Fgenerated-sources%2Fantlr4%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fautogen%2FSQLServerStatementParser.java#L359) | 4293 | 29.93% |
   <!-- | **Total:** | **4296** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/33061790/badge)](https://coveralls.io/builds/33061790) |
   | :-- | --: |
   | Change from base [Build 14196](https://coveralls.io/builds/33046222): |  0.06% |
   | Covered Lines: | 35279 |
   | Relevant Lines: | 99916 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] jingshanglu commented on pull request #7111: Add with segment parser for SQLServer insert statement.

Posted by GitBox <gi...@apache.org>.
jingshanglu commented on pull request #7111:
URL: https://github.com/apache/shardingsphere/pull/7111#issuecomment-682464760


   @dongzl @tristaZero withClause is optional, MySQL has not withClause in insertStatement, maybe it is better to create subclass of InsertStatement, what do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero commented on pull request #7111: Add with segment parser for SQLServer insert statement.

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #7111:
URL: https://github.com/apache/shardingsphere/pull/7111#issuecomment-683284510


   Hi @dongzl @jingshanglu Got it.
   I suppose it is required to review all of the current SQL statements and consider splitting them into various subclasses in terms of SQL dialects. But it needs some time to reflect its process and architecture. Besides, If we deal with two of these things together, that will frustrate us. So I suggest merging this one and later for that splitting work.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org