You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "tkobayas (via GitHub)" <gi...@apache.org> on 2024/03/27 10:15:44 UTC

[I] [new-parser] review drlExpression and drlPrimary in DRLParser.g4 [incubator-kie-drools]

tkobayas opened a new issue, #5807:
URL: https://github.com/apache/incubator-kie-drools/issues/5807

   https://github.com/apache/incubator-kie-drools/pull/5806#discussion_r1540800031
   
   `drlExpression` and `drlPrimary` in `DRLParser.g4` are extended rules from `JavaParser.g4`.
   
   However, constraint related rules should respect `DRL6Expressions.g4` so that we can avoid a situation like "This is possible with DRL6Expressions, but not possible with DRLParser". It would also be a good way to find additional unit tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [I] [new-parser] review drlExpression and drlPrimary in DRLParser.g4 [incubator-kie-drools]

Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on issue #5807:
URL: https://github.com/apache/incubator-kie-drools/issues/5807#issuecomment-2111985392

   Not high priority


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [I] [new-parser] review drlExpression and drlPrimary in DRLParser.g4 [incubator-kie-drools]

Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on issue #5807:
URL: https://github.com/apache/incubator-kie-drools/issues/5807#issuecomment-2087854083

   We have imported  `DRL6Expressions.g4`. This issue could be used to review and clean up unnecessary rules in `DRLParser.g4`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org